Sign upLogin

react-epfl/chachachat

View on GitHub
Star

Showing 22 of 22 total issues

File dictionary.js has 2012 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Dictionary model
 */

'use strict';
Severity: Major
Found in models/dictionary.js - About 5 days to fix

    File user.js has 465 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * User model
 */

'use strict';
    Severity: Minor
    Found in models/user.js - About 7 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.onGetUserPhrases = function (socket, event) {
  return function(data, res) {
    var userId = socket.handshake.user.id;

    app.User.getUserPhrases(userId, function(err, userPhrases) {
      Severity: Major
      Found in controllers/user.js and 1 other location - About 3 hrs to fix
      controllers/user.js on lines 141..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      exports.onGetAchievements = function(socket, event) {
  return function(data, res) {
    var userId = socket.handshake.user.id;

    app.User.getUserAchievements(userId, function(err, userAchievements) {
      Severity: Major
      Found in controllers/user.js and 1 other location - About 3 hrs to fix
      controllers/user.js on lines 83..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            function(user, callback){
        // checking Talk To Me
        var achName = 'Talk To Me';
        var receivedAchievementLevels = [1, 10, 50, 100, 300, 500, 1000, 2000, 5000, 10000];
        var curValue = user.msgReceivedCount;
      Severity: Major
      Found in models/user.js and 1 other location - About 3 hrs to fix
      models/user.js on lines 274..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            function(user, callback){
        // checking Cool Kid
        var achName = 'Cool Kid';
        var receivedAchievementLevels =  [1, 5, 10, 20, 30, 40, 50, 100, 200, 500];
        var curValue = user.roomsCount;
      Severity: Major
      Found in models/user.js and 1 other location - About 3 hrs to fix
      models/user.js on lines 261..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function onSendMessage has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        onSendMessage: function(socket, event) {
    return function(jsonMessage) {
      var author = socket.handshake.user.id;

      report.debug('user ' + author + ' sends message ' + JSON.stringify(jsonMessage));
      Severity: Major
      Found in controllers/room.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            socket.error404 = function(event, message, err) {
      report.warn('On ' + event + ': ' + message + ', with error ' + err);

      socket.emit(event, {
        status: 404,
        Severity: Major
        Found in reporter.js and 1 other location - About 1 hr to fix
        reporter.js on lines 15..22

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            app.User.getProfileStats(userId, function(err, profileStats) {
      if (err) {
        return socket.error500(event, 'Could not get profile stats', err);
      }
        Severity: Major
        Found in controllers/user.js and 1 other location - About 1 hr to fix
        controllers/user.js on lines 40..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            socket.error500 = function(event, message, err) {
      report.error('On ' + event + ': ' + message + ', with error ' + err);

      socket.emit(event, {
        status: 500,
        Severity: Major
        Found in reporter.js and 1 other location - About 1 hr to fix
        reporter.js on lines 24..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            app.User.getProfileChars(userId, function(err, profileChars) {
      if (err) {
        return socket.error500(event, 'Could not get profile characteristics', err);
      }
        Severity: Major
        Found in controllers/user.js and 1 other location - About 1 hr to fix
        controllers/user.js on lines 56..64

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function checkAchievementsAndNotify has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          checkAchievementsAndNotify : function (user) {
    // on each step we check one achievement, update the user object
    // and notify the client about new achievements
    async.waterfall([
      function(callback){
        Severity: Minor
        Found in models/user.js - About 1 hr to fix

          Function getUserAchievements has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getUserAchievements : function (userId, cb) {
  // TODO: for some reason it is called even before the profileChars are set during registration
    app.User.findById(userId, function (err, user) {
      if (err) return cb(err);
          Severity: Minor
          Found in models/user.js - About 1 hr to fix

            Function addMessage has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              addMessage: function(message, cb) {
    this.messages.push(message);
    this.color = message.color; // the user will have a color of the last sent message

    this.save(function(err, room) {
            Severity: Minor
            Found in models/room.js - About 1 hr to fix

              Function register has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                register : function(reqUser, cb) {
    try {
      var salt = crypto.randomBytes(128).toString('base64');
      var hashedpw = crypto.pbkdf2Sync(reqUser.password, salt, 16384, 256).toString('base64');
              Severity: Minor
              Found in models/user.js - About 1 hr to fix

                Function check has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
                Severity: Minor
                Found in models/achievement.js - About 1 hr to fix

                  Function createRoom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    createRoom : function(userIds, cb) {
    var matches = userIds.map(function(userId) {
      return { "$elemMatch": { userId: ObjectId(userId) } }
    });
                  Severity: Minor
                  Found in models/room.js - About 1 hr to fix

                    Function check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                      check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
                    Severity: Minor
                    Found in models/achievement.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function check has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      check : function(user, achName, achLevels, curValue, cb) {
                    Severity: Minor
                    Found in models/achievement.js - About 35 mins to fix

                      Function setProfileChars has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        setProfileChars : function (userId, newChars, cb) {
    app.User.findById(userId, 'profile', function (err, user) {
      if (err) return cb(err);

      var charsLength = newChars.length;
                      Severity: Minor
                      Found in models/user.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language