Sign upLogin

react-epfl/chachachat

View on GitHub
Star

Showing 14 of 22 total issues

File dictionary.js has 2012 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Dictionary model
 */

'use strict';
Severity: Major
Found in models/dictionary.js - About 5 days to fix

    File user.js has 465 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * User model
 */

'use strict';
    Severity: Minor
    Found in models/user.js - About 7 hrs to fix

      Function onSendMessage has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        onSendMessage: function(socket, event) {
    return function(jsonMessage) {
      var author = socket.handshake.user.id;

      report.debug('user ' + author + ' sends message ' + JSON.stringify(jsonMessage));
      Severity: Major
      Found in controllers/room.js - About 2 hrs to fix

        Function checkAchievementsAndNotify has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          checkAchievementsAndNotify : function (user) {
    // on each step we check one achievement, update the user object
    // and notify the client about new achievements
    async.waterfall([
      function(callback){
        Severity: Minor
        Found in models/user.js - About 1 hr to fix

          Function getUserAchievements has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getUserAchievements : function (userId, cb) {
  // TODO: for some reason it is called even before the profileChars are set during registration
    app.User.findById(userId, function (err, user) {
      if (err) return cb(err);
          Severity: Minor
          Found in models/user.js - About 1 hr to fix

            Function addMessage has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              addMessage: function(message, cb) {
    this.messages.push(message);
    this.color = message.color; // the user will have a color of the last sent message

    this.save(function(err, room) {
            Severity: Minor
            Found in models/room.js - About 1 hr to fix

              Function register has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                register : function(reqUser, cb) {
    try {
      var salt = crypto.randomBytes(128).toString('base64');
      var hashedpw = crypto.pbkdf2Sync(reqUser.password, salt, 16384, 256).toString('base64');
              Severity: Minor
              Found in models/user.js - About 1 hr to fix

                Function check has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
                Severity: Minor
                Found in models/achievement.js - About 1 hr to fix

                  Function createRoom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    createRoom : function(userIds, cb) {
    var matches = userIds.map(function(userId) {
      return { "$elemMatch": { userId: ObjectId(userId) } }
    });
                  Severity: Minor
                  Found in models/room.js - About 1 hr to fix

                    Function check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                      check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
                    Severity: Minor
                    Found in models/achievement.js - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function check has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      check : function(user, achName, achLevels, curValue, cb) {
                    Severity: Minor
                    Found in models/achievement.js - About 35 mins to fix

                      Function setProfileChars has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        setProfileChars : function (userId, newChars, cb) {
    app.User.findById(userId, 'profile', function (err, user) {
      if (err) return cb(err);

      var charsLength = newChars.length;
                      Severity: Minor
                      Found in models/user.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function apiLogin has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      var apiLogin = function(req, res, next) {
  passport.authenticate('local', function(err, user) {
    if (err) {
      return res.status(500).sendfile('public/login.html');
    }
                      Severity: Minor
                      Found in server.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function achievementForName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        achievementForName : function(name) {
    var achievement = null;

    // TODO: use hash instead of array to avoid this lookup
    if (this.achievements) {
                      Severity: Minor
                      Found in models/user.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language