Sign upLogin

react-epfl/chachachat

View on GitHub
Star
models/achievement.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function check has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
Severity: Minor
Found in models/achievement.js - About 1 hr to fix

    Function check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      check : function(user, achName, achLevels, curValue, cb) {
    if (!user.achievements) return; // a dirty hack since sometimes this field is undefined

    var newLevel = 0; // the achievement was not assigned yet
    Severity: Minor
    Found in models/achievement.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function check has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      check : function(user, achName, achLevels, curValue, cb) {
    Severity: Minor
    Found in models/achievement.js - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status