Sign upLogin

react-tags/react-tags

View on GitHub
Star

Showing 42 of 42 total issues

File ReactTags.test.tsx has 1213 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { expect } from 'chai';
import { spy, stub, createSandbox } from 'sinon';

import { WithContext as ReactTags } from '../src/index';
Severity: Major
Found in __tests__/ReactTags.test.tsx - About 3 days to fix

    Function ReactTags has 463 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const ReactTags = (props: ReactTagsProps) => {
  const {
    autofocus,
    autoFocus,
    readOnly,
    Severity: Major
    Found in src/components/ReactTags.tsx - About 2 days to fix

      Function ReactTags has a Cognitive Complexity of 91 (exceeds 5 allowed). Consider refactoring.
      Open

      const ReactTags = (props: ReactTagsProps) => {
  const {
    autofocus,
    autoFocus,
    readOnly,
      Severity: Minor
      Found in src/components/ReactTags.tsx - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File ReactTags.tsx has 502 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import React, { useEffect, createRef, useRef, useState, Fragment } from 'react';
import uniq from 'lodash/uniq';
import ClearAllTags from './ClearAllTags';
import Suggestions from './Suggestions';
import ClassNames from 'classnames';
      Severity: Major
      Found in src/components/ReactTags.tsx - About 1 day to fix

        Function ReactTagsWrapper has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const ReactTagsWrapper = (props: ReactTagsWrapperProps) => {
  const {
    placeholder = DEFAULT_PLACEHOLDER,
    labelField = DEFAULT_LABEL_FIELD,
    suggestions = [],
        Severity: Major
        Found in src/index.tsx - About 3 hrs to fix

          Function SuggestionsComp has 71 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const SuggestionsComp = (props: SuggestionsProps) => {
  const suggestionsContainerRef = createRef<HTMLDivElement>();
  const {
    labelField,
    minQueryLength,
          Severity: Major
          Found in src/components/Suggestions.tsx - About 2 hrs to fix

            Function SingleTag has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const SingleTag = (props: TagProps) => {
  const tagRef = useRef(null);
  const {
    readOnly = false,
    tag,
            Severity: Major
            Found in src/components/SingleTag.tsx - About 2 hrs to fix

              Function App has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const App = () => {
  const [tags, setTags] = React.useState<Array<Tag>>([
    { id: 'Thailand', text: 'Thailand', className: '' },
    { id: 'India', text: 'India', className: '' },
    { id: 'Vietnam', text: 'Vietnam', className: '' },
              Severity: Major
              Found in example/main.tsx - About 2 hrs to fix

                Function handleKeyDown has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  const handleKeyDown = (event: React.KeyboardEvent<HTMLInputElement>) => {
    // hide suggestions menu on escape
    if (event.key === 'Escape') {
      event.preventDefault();
      event.stopPropagation();
                Severity: Minor
                Found in src/components/ReactTags.tsx - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    it('should not focus on input if autoFocus is false', () => {
    const { unmount } = render(mockItem({ autoFocus: false }));
    expect(document.activeElement?.tagName).to.equal('BODY');
    unmount();
  });
                  Severity: Major
                  Found in __tests__/ReactTags.test.tsx and 1 other location - About 1 hr to fix
                  __tests__/ReactTags.test.tsx on lines 90..94

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    it('should not focus on input if autofocus is false', () => {
    const { unmount } = render(mockItem({ autofocus: false }));
    expect(document.activeElement?.tagName).to.equal('BODY');
    unmount();
  });
                  Severity: Major
                  Found in __tests__/ReactTags.test.tsx and 1 other location - About 1 hr to fix
                  __tests__/ReactTags.test.tsx on lines 96..100

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 73.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function RemoveComponent has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  const RemoveComponent = (props: RemoveComponentProps) => {
  const { readOnly, removeComponent, onRemove, className, tag, index } = props;

  const onKeydown = (event: React.KeyboardEvent<HTMLButtonElement>) => {
    if (KEYS.ENTER.includes(event.keyCode) || event.keyCode === KEYS.SPACE) {
                  Severity: Minor
                  Found in src/components/RemoveComponent.tsx - About 1 hr to fix

                    Function getTagItems has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      const getTagItems = () => {
    const allClassNames = { ...DEFAULT_CLASSNAMES, ...props.classNames };

    return tags.map((tag, index) => {
      return (
                    Severity: Minor
                    Found in src/components/ReactTags.tsx - About 1 hr to fix

                      Function handlePaste has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        const handlePaste = (event: React.ClipboardEvent<HTMLInputElement>) => {
    if (!allowAdditionFromPaste) {
      return;
    }
                      Severity: Minor
                      Found in src/components/ReactTags.tsx - About 1 hr to fix

                        Function addTag has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          const addTag = (tag: Tag) => {
    if (!tag.id || !tag[labelField]) {
      return;
    }
                        Severity: Minor
                        Found in src/components/ReactTags.tsx - About 1 hr to fix

                          Function GitHubCorner has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          const GitHubCorner = () => {
  return (
    <>
      <a
        href="https://github.com/react-tags/react-tags"
                          Severity: Minor
                          Found in example/GithubCorner.tsx - About 1 hr to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                  render(
        mockItem({
          delimiters: [Keys.TAB, Keys.SPACE, Keys.COMMA],
          handleAddition(tag) {
            tags.push(tag);
                            Severity: Major
                            Found in __tests__/ReactTags.test.tsx and 2 other locations - About 1 hr to fix
                            __tests__/ReactTags.test.tsx on lines 387..395
                            __tests__/ReactTags.test.tsx on lines 602..610

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                  render(
        mockItem({
          separators: [SEPARATORS.TAB, SEPARATORS.SPACE, SEPARATORS.COMMA],
          handleAddition(tag) {
            tags.push(tag);
                            Severity: Major
                            Found in __tests__/ReactTags.test.tsx and 2 other locations - About 1 hr to fix
                            __tests__/ReactTags.test.tsx on lines 263..271
                            __tests__/ReactTags.test.tsx on lines 602..610

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  const container = render(
        mockItem({
          readOnly: true,
          tags: [
            ...defaults.tags,
                            Severity: Major
                            Found in __tests__/ReactTags.test.tsx and 1 other location - About 1 hr to fix
                            __tests__/ReactTags.test.tsx on lines 1261..1270

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  const tags = render(
        mockItem({
          editable: true,
          tags: [
            ...defaults.tags,
                            Severity: Major
                            Found in __tests__/ReactTags.test.tsx and 1 other location - About 1 hr to fix
                            __tests__/ReactTags.test.tsx on lines 143..152

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language