Sign upLogin

reactjs/redux

View on GitHub
Star
src/createStore.ts

Summary

Maintainability
D
2 days
Test Coverage

Function createStore has 177 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createStore<
  S,
  A extends Action,
  Ext extends {} = {},
  StateExt extends {} = {},
Severity: Major
Found in src/createStore.ts - About 7 hrs to fix

    Function createStore has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
    Open

    export function createStore<
  S,
  A extends Action,
  Ext extends {} = {},
  StateExt extends {} = {},
    Severity: Minor
    Found in src/createStore.ts - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File createStore.ts has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import $$observable from './utils/symbol-observable'

import type {
  Store,
  StoreEnhancer,
    Severity: Minor
    Found in src/createStore.ts - About 2 hrs to fix

      Function subscribe has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function subscribe(listener: () => void) {
    if (typeof listener !== 'function') {
      throw new Error(
        `Expected the listener to be a function. Instead, received: '${kindOf(
          listener
      Severity: Minor
      Found in src/createStore.ts - About 1 hr to fix

        Function dispatch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function dispatch(action: A) {
    if (!isPlainObject(action)) {
      throw new Error(
        `Actions must be plain objects. Instead, the actual type was: '${kindOf(
          action
        Severity: Minor
        Found in src/createStore.ts - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          export function legacy_createStore<
  S,
  A extends Action,
  Ext extends {} = {},
  StateExt extends {} = {},
          Severity: Minor
          Found in src/createStore.ts and 1 other location - About 35 mins to fix
          src/createStore.ts on lines 85..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          export function createStore<
  S,
  A extends Action,
  Ext extends {} = {},
  StateExt extends {} = {},
          Severity: Minor
          Found in src/createStore.ts and 1 other location - About 35 mins to fix
          src/createStore.ts on lines 476..486

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status