reactphp/socket-client

View on GitHub

Showing 6 of 6 total issues

Method __construct has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(LoopInterface $loop, array $options = array())
    {
        // apply default options if not explicitly given
        $options += array(
            'tcp' => true,
Severity: Major
Found in src/Connector.php - About 2 hrs to fix

    Function __construct has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(LoopInterface $loop, array $options = array())
        {
            // apply default options if not explicitly given
            $options += array(
                'tcp' => true,
    Severity: Minor
    Found in src/Connector.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method connect has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function connect($uri)
        {
            if (strpos($uri, '://') === false) {
                $uri = 'tcp://' . $uri;
            }
    Severity: Major
    Found in src/TcpConnector.php - About 2 hrs to fix

      Method connect has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function connect($uri)
          {
              if (strpos($uri, '://') === false) {
                  $parts = parse_url('tcp://' . $uri);
                  unset($parts['scheme']);
      Severity: Minor
      Found in src/DnsConnector.php - About 1 hr to fix

        Function connect has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function connect($uri)
            {
                if (strpos($uri, '://') === false) {
                    $uri = 'tcp://' . $uri;
                }
        Severity: Minor
        Found in src/TcpConnector.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method connect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function connect($uri)
            {
                if (!function_exists('stream_socket_enable_crypto')) {
                    return Promise\reject(new \BadMethodCallException('Encryption not supported on your platform (HHVM < 3.8?)'));
                }
        Severity: Minor
        Found in src/SecureConnector.php - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language