Sign upLogin

realitix/vulk

View on GitHub
Star
vulk/graphic/d2/batch.py

Summary

Maintainability
F
4 days
Test Coverage

File batch.py has 687 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'''BaseBatch module

BaseBatch is used by SpriteBatch and BlockBatch.
'''
from abc import ABC, abstractmethod
Severity: Major
Found in vulk/graphic/d2/batch.py - About 1 day to fix

    Function draw has 16 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def draw(self, texture, x, y, width=0, height=0, u=0, v=0, u2=1, v2=1,
    Severity: Major
    Found in vulk/graphic/d2/batch.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method draw. (7)
      Open

          def draw(self, texture, x, y, width=0, height=0, u=0, v=0, u2=1, v2=1,
             r=1, g=1, b=1, a=1, scale_x=1, scale_y=1, rotation=0):
        '''
        Draw `texture` at position x, y of size `width`, `height`
      Severity: Minor
      Found in vulk/graphic/d2/batch.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function draw_region has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def draw_region(self, region, x, y, width, height, r=1, g=1, b=1, a=1,
      Severity: Major
      Found in vulk/graphic/d2/batch.py - About 1 hr to fix

        Function draw_char has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def draw_char(self, fontdata, char, x, y, r=1., g=1., b=1., a=1.,
        Severity: Major
        Found in vulk/graphic/d2/batch.py - About 1 hr to fix

          Function draw has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def draw(self, texture, x, y, width=0, height=0, u=0, v=0, u2=1, v2=1,
             r=1, g=1, b=1, a=1, scale_x=1, scale_y=1, rotation=0):
        '''
        Draw `texture` at position x, y of size `width`, `height`
          Severity: Minor
          Found in vulk/graphic/d2/batch.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  with self.cbpool.pull() as cmd:
            width = self.context.width
            height = self.context.height
            cmd.begin_renderpass(
                self.renderpass,
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 1 other location - About 1 day to fix
          vulk/graphic/d3/batch.py on lines 27..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def get_default_shaderprogram(self, context):
        '''Generate a basic shader program if none given

        *Parameters:*
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 2 other locations - About 3 hrs to fix
          vulk/graphic/d2/batch.py on lines 663..678
          vulk/graphic/d2/batch.py on lines 885..900

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def get_default_shaderprogram(self, context):
        '''Generate a basic shader program if nono given

        *Parameters:*
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 2 other locations - About 3 hrs to fix
          vulk/graphic/d2/batch.py on lines 435..450
          vulk/graphic/d2/batch.py on lines 885..900

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              def get_default_shaderprogram(self, context):
        '''Generate a basic shader program if nono given

        *Parameters:*
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 2 other locations - About 3 hrs to fix
          vulk/graphic/d2/batch.py on lines 435..450
          vulk/graphic/d2/batch.py on lines 663..678

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, context, size=1000, shaderprogram=None,
                 out_view=None):
        super().__init__(context, size, shaderprogram, out_view)

        self.dspool = self.init_dspool()
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 1 other location - About 1 hr to fix
          vulk/graphic/d2/batch.py on lines 601..606

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, context, size=1000, shaderprogram=None,
                 out_view=None):
        super().__init__(context, size, shaderprogram, out_view)

        self.dspool = self.init_dspool()
          Severity: Major
          Found in vulk/graphic/d2/batch.py and 1 other location - About 1 hr to fix
          vulk/graphic/d2/batch.py on lines 878..883

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status