Showing 8 of 8 total issues
Function CreateNewContainer
has 118 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func CreateNewContainer(command *api.Command, vars []string) (string, error) {
cli, err := containers.CreateNewClient()
if err != nil {
return "", err
}
Function Login
has 77 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func Login() error {
config, err := configuration.ReadConfig()
if err != nil {
return err
}
Function CreateNewContainer
has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring. Open
Open
func CreateNewContainer(command *api.Command, vars []string) (string, error) {
cli, err := containers.CreateNewClient()
if err != nil {
return "", err
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function CreateNewContainer
has 9 return statements (exceeds 4 allowed). Open
Open
func CreateNewContainer(command *api.Command, vars []string) (string, error) {
cli, err := containers.CreateNewClient()
if err != nil {
return "", err
}
Function Login
has 8 return statements (exceeds 4 allowed). Open
Open
func Login() error {
config, err := configuration.ReadConfig()
if err != nil {
return err
}
Function Upload
has 8 return statements (exceeds 4 allowed). Open
Open
func Upload(client *http.Client, url string, outputFileName string, commandId int, taskId int) (err error) {
if _, err := os.Stat(outputFileName); os.IsNotExist(err) {
return fmt.Errorf("Output file '%s' could not be found", outputFileName)
}
Function Logout
has 7 return statements (exceeds 4 allowed). Open
Open
func Logout() error {
if _, err := api.ReadSessionToken(); err != nil {
return errors.New("There is no active user session")
}
Function Upload
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func Upload(client *http.Client, url string, outputFileName string, commandId int, taskId int) (err error) {