recurly/recurly-js

View on GitHub
lib/recurly/pricing/checkout/index.js

Summary

Maintainability
D
1 day
Test Coverage

File index.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import clone from 'component-clone';
import find from 'component-find';
import intersection from 'intersect';
import isEmpty from 'lodash.isempty';
import Promise from 'promise';
Severity: Minor
Found in lib/recurly/pricing/checkout/index.js - About 3 hrs to fix

    Function adjustment has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      adjustment ({ itemCode = null, amount, quantity, id = uid(), currency, taxExempt, taxCode }) {
        const { recurly } = this;
        return new PricingPromise((resolve, reject) => {
          let existingAdjustment = find(this.items.adjustments, a => a.id === id);
          let validateAmount = true;
    Severity: Major
    Found in lib/recurly/pricing/checkout/index.js - About 2 hrs to fix

      CheckoutPricing has 23 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export default class CheckoutPricing extends Pricing {
        constructor (...args) {
          super(...args);
          this.debug = debug;
          this.recurly.report('pricing:checkout:create');
      Severity: Minor
      Found in lib/recurly/pricing/checkout/index.js - About 2 hrs to fix

        Function subscription has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          subscription (subscription) {
            return new PricingPromise((resolve, reject) => {
              if (!(subscription instanceof SubscriptionPricing)) {
                return this.error(errors('invalid-option', {
                  name: 'subscription',
        Severity: Minor
        Found in lib/recurly/pricing/checkout/index.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            attach (container) {
              if (this.attachment) this.attachment.detach();
              this.attachment = new Attachment(this, container);
              this.attachment.once('ready', () => this.emit('attached'));
              return this.attachment;
          Severity: Major
          Found in lib/recurly/pricing/checkout/index.js and 1 other location - About 2 hrs to fix
          lib/recurly/pricing/subscription/index.js on lines 67..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status