Sign upLogin

red6/dmn-check

View on GitHub
Star
validators/src/main/java/de/redsix/dmncheck/validators/OutputValuesTypeValidator.java

Summary

Maintainability
A
55 mins
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        return ExpressionTypeParser.parse(expressionType, validationContext.getItemDefinitions())
                .match(
                        validationResult -> Collections.singletonList(
                                validationResult.element(output).build()),
                        inputType -> typecheck(
Severity: Minor
Found in validators/src/main/java/de/redsix/dmncheck/validators/OutputValuesTypeValidator.java and 1 other location - About 55 mins to fix
validators/src/main/java/de/redsix/dmncheck/validators/InputValuesTypeValidator.java on lines 26..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is longer than 100 characters (found 101).
Open

                && ExpressionTypeParser.parse(expressionType, validationContext.getItemDefinitions())
Severity: Minor
Found in validators/src/main/java/de/redsix/dmncheck/validators/OutputValuesTypeValidator.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 102).
Open

    public List<ValidationResult> validate(final Output output, ValidationContext validationContext) {
Severity: Minor
Found in validators/src/main/java/de/redsix/dmncheck/validators/OutputValuesTypeValidator.java by checkstyle

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status