Sign upLogin

redbadger/pride-london-app

View on GitHub
Star

Showing 24 of 26 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  updateActiveTabLine = () => {
    const { navigation } = this.props;
    const currentIndex = navigation.state.index;
    const layout = this.tabLayouts[currentIndex];
    if (!layout || !this.tabBarLayout) {
Severity: Major
Found in src/components/TopTabBar.js and 1 other location - About 1 day to fix
src/components/NavigationTabBar.js on lines 39..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 207.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  updateActiveTabLine = () => {
    const { navigation } = this.props;
    const currentIndex = navigation.state.index;
    const layout = this.tabLayouts[currentIndex];
    if (!layout || !this.tabBarLayout) {
Severity: Major
Found in src/components/NavigationTabBar.js and 1 other location - About 1 day to fix
src/components/TopTabBar.js on lines 38..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 207.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File __test-data.js has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow
// $FlowFixMe
import { gen, sampleOne as sample } from "@rgbboy/testcheck"; // eslint-disable-line import/no-extraneous-dependencies
// $FlowFixMe
import type { ValueGenerator } from "@rgbboy/testcheck";
Severity: Minor
Found in src/data/__test-data.js - About 6 hrs to fix

    File event.js has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // @flow
import R from "ramda";
import {
  set as setDate,
  diff as diffDate,
    Severity: Minor
    Found in src/data/event.js - About 3 hrs to fix

      File Navigation.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // @flow
import React from "react";
import {
  createBottomTabNavigator,
  createMaterialTopTabNavigator,
      Severity: Minor
      Found in src/Navigation.js - About 3 hrs to fix

        Function render has 104 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

          render() {
    const {
      savedEvents,
      addSavedEvent,
      removeSavedEvent,
        Severity: Major
        Found in src/screens/ParadeMapScreen/Map.js - About 3 hrs to fix

          File Map.js has 282 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          // @flow
import React, { PureComponent } from "react";
import type { ElementRef } from "react";
import {
  Image,
          Severity: Minor
          Found in src/screens/ParadeMapScreen/Map.js - About 2 hrs to fix

            Function render has 78 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

              render() {
    const { event, navigation, performances, setCategoryFilter } = this.props;
    return (
      <View style={styles.container} testID="event-details-screen">
        <EventHeader
            Severity: Major
            Found in src/screens/EventDetailsScreen/component.js - About 2 hrs to fix

              Function getEventCategoryFromName has 70 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              export const getEventCategoryFromName = (
  category: EventCategoryName
): EventCategory => {
  switch (category) {
    case "Cabaret and Variety":
              Severity: Major
              Found in src/data/event.js - About 1 hr to fix

                Function render has 69 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                  render() {
    const { navigation, sponsors } = this.props;

    const sortByName = R.sortBy(sponsor =>
      sponsor.fields.sponsorName.toLowerCase()
                Severity: Major
                Found in src/screens/SponsorScreen/component.js - About 1 hr to fix

                  Function render has 68 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                    render() {
    const {
      loading,
      headerBanners,
      featuredEvents,
                  Severity: Major
                  Found in src/screens/HomeScreen/component.js - About 1 hr to fix

                    Function getAccessibiltyLabel has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const getAccessibiltyLabel = (
  label: string,
  placeholder: ?string,
  value: ?string,
  focused: boolean,
                    Severity: Minor
                    Found in src/screens/DonateScreen/accessibilityLabel.ios.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function render has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                      render() {
    const { navigation, getTabTestID } = this.props;
    const { routes } = navigation.state;

    const activeTabLineScale = Animated.divide(
                    Severity: Major
                    Found in src/components/NavigationTabBar.js - About 1 hr to fix

                      Function renderContent has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                        renderContent() {
    const { selectedAmount, otherAmount } = this.state;
    return (
      <ScrollView ref={this.scrollViewRef}>
        <SafeAreaView style={styles.scrollContainer}>
                      Severity: Major
                      Found in src/screens/DonateScreen/index.js - About 1 hr to fix

                        Function EventFilters has 56 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        const EventFilters = (now: void => DateTime) => {
  const defaultState: State = createEventFiltersState(now());
  return (state: State = defaultState, action: Action): State => {
    let filters;
    switch (action.type) {
                        Severity: Major
                        Found in src/reducers/event-filters.js - About 1 hr to fix

                          Function render has 54 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                            render() {
    const {
      id,
      name,
      locationName,
                          Severity: Major
                          Found in src/components/EventCard.js - About 1 hr to fix

                            Function render has 53 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                              render() {
    const {
      color,
      title,
      description,
                            Severity: Major
                            Found in src/components/ButtonWithShapes.js - About 1 hr to fix

                              Function render has 53 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                                render() {
    const { navigation, getTabTestID } = this.props;
    const { routes } = navigation.state;

    const activeTabLineScale = Animated.divide(
                              Severity: Major
                              Found in src/components/TopTabBar.js - About 1 hr to fix

                                Function buildEventFilter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                Open

                                export const buildEventFilter = (
  showEventsAfter: DateTime,
  {
    date,
    timeOfDay,
                                Severity: Minor
                                Found in src/selectors/event-filters.js - About 55 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  render() {
    const { event, navigation, performances, setCategoryFilter } = this.props;
    return (
      <View style={styles.container} testID="event-details-screen">
        <EventHeader
                                Severity: Minor
                                Found in src/screens/EventDetailsScreen/component.js - About 45 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language