Sign upLogin

redbadger/react.london

View on GitHub
Star

Showing 363 of 363 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function router(req, res) {
  if (req.path === '/conference') {
    return res.redirect(CONFERENCE_URL);
  }
  getCommunityState()
Severity: Major
Found in server/routers/community/index.js and 1 other location - About 4 hrs to fix
server/routers/conference/index.js on lines 9..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function router(req, res) {
  if (req.path === '/community') {
    return res.redirect(COMMUNITY_URL);
  }
  getConferenceState()
Severity: Major
Found in server/routers/conference/index.js and 1 other location - About 4 hrs to fix
server/routers/community/index.js on lines 9..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    return (
      <nav className="NavigationBar block NavigationBar--Conference">
        <div className="NavigationBar__links-container block">
          <input
Severity: Major
Found in shared/components/NavigationBar/index.js - About 2 hrs to fix

    Function ConferencePartners has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const ConferencePartners = (props) => {
  const { gold, silver, bronze, supporter } = props;
  return (
    <div>
      <section className="block ConferencePartners__about">
    Severity: Minor
    Found in shared/components/ConferencePartners/index.js - About 1 hr to fix

      Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
    const {
      title,
      startDateTime,
      endDateTime,
      Severity: Minor
      Found in shared/components/NextCommunityEvent/index.js - About 1 hr to fix

        Function SchedulePageOverview has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const SchedulePageOverview = (props) => {
  return (
    <div className="SchedulePageOverview block">
      <div className="content">
        <div className="SchedulePageOverview__container">
        Severity: Minor
        Found in shared/components/SchedulePageOverview/index.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          if (isMeetupRequest(window.location)) {
  components = (
    <Router
      history={browserHistory}
      render={applyRouterMiddleware(useScroll())}
          Severity: Major
          Found in client/index.js and 1 other location - About 1 hr to fix
          client/index.js on lines 44..54

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          } else {
  components = (
    <Router
      history={browserHistory}
      render={applyRouterMiddleware(useScroll())}
          Severity: Major
          Found in client/index.js and 1 other location - About 1 hr to fix
          client/index.js on lines 34..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getHeaderText has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export function getHeaderText(startDateTime, endDateTime) {
  if (!startDateTime || !endDateTime) {
    return 'Community Meetup';
  }
  const currentDateTime = moment();
          Severity: Minor
          Found in shared/components/NextCommunityEvent/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Prefer default export.
          Open

          export function getEnvVar(key) {
          Severity: Minor
          Found in server/env.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          propType "streamingLink" is not required, but has no corresponding defaultProp declaration.
          Open

            streamingLink: PropTypes.string,
          Severity: Minor
          Found in shared/components/ArchivedCommunityEvent/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          Absolute imports should come before relative imports.
          Open

          import { shallow } from 'enzyme';
          Severity: Minor
          Found in shared/components/CommunityAbout/test.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          JSX not allowed in files with extension '.js'
          Open

            <div className="CommunityLayout">
          Severity: Minor
          Found in shared/components/CommunityLayout/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          JSX not allowed in files with extension '.js'
          Open

            <div className="ConferenceHighlights block">
          Severity: Minor
          Found in shared/components/ConferenceHightlights/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          JSX not allowed in files with extension '.js'
          Open

            <a
          Severity: Minor
          Found in shared/components/ConferenceHightlights/slideshare.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          propType "page" is not required, but has no corresponding defaultProp declaration.
          Open

            page: pageType,
          Severity: Minor
          Found in shared/components/Hero/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          JSX not allowed in files with extension '.js'
          Open

            const output = shallow(<Hero {...props} />);
          Severity: Minor
          Found in shared/components/Hero/test.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          JSX not allowed in files with extension '.js'
          Open

            <div className="InterestedSpeaker">
          Severity: Minor
          Found in shared/components/InterestedSpeaker/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener
          Open

              target="_blank"
          Severity: Minor
          Found in shared/components/ConferenceHightlights/slideshare.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          propType "bronze" is not required, but has no corresponding defaultProp declaration.
          Open

            bronze: PartnersSection.propTypes.partners,
          Severity: Minor
          Found in shared/components/ConferencePartners/index.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          Severity
          Category
          Status
          Source
          Language