Sign upLogin

redbrick/static-site

View on GitHub
Star

Showing 4 of 4 total issues

Function emailNewPosts has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function emailNewPosts (callback) {
  logger.info('Sending email update(s) for any new posts...');
  readFileAsArray(mailingListFilename, (err, addresses) => {
    if (err) {
      return bail(`Unable to read file: ${mailingListFilename}`, callback);
Severity: Major
Found in lib/emailNewPosts.js - About 2 hrs to fix

Function getLatestPosts has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getLatestPosts = (options) => {
  return new Promise((resolve, reject) => {
    options.offset = options.offset || 0;
    options.limit = options.limit || 10;
    options.include = options.include || [];
Severity: Minor
Found in lib/getLatestPosts.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  } else {
    sendMailTransport.sendMail(mailOptions, err => {
      if (err) {
        logger.error(`sendMail failed: ${err}\nUnable to send email "${subject}" to recipient: ${address}`);
      }
Severity: Major
Found in lib/emailNewPosts.js and 1 other location - About 1 hr to fix
lib/emailNewPosts.js on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (!config.useSendMail || sendMailDefault) {
    smtpTransport.sendMail(mailOptions, err => {
      if (err) {
        logger.error(`SMTP failed: ${err}\nUnable to send email "${subject}" to recipient: ${address}`);
      }
Severity: Major
Found in lib/emailNewPosts.js and 1 other location - About 1 hr to fix
lib/emailNewPosts.js on lines 39..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language