redjazz96/steam-mist

View on GitHub

Showing 3 of 3 total issues

Method with_cache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def with_cache(force = false)
      if cache
        headers['If-Modified-Since'] = cache[:last_modified].utc.rfc2822
      end

Severity: Minor
Found in lib/steam_mist/connector.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def cache(force = false)
      return nil unless cache? && File.exists?(@cache)

      @_cache = if force || !@_cache
        File.open(@cache) { |f| Oj.load(f) }[request_uri.to_s]
Severity: Minor
Found in lib/steam_mist/connector.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send_packet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def send_packet(packet)
        empty_packet = @empty_packet.dup
        empty_packet.id = packet.id
        write(packet) and write(empty_packet)
        response_packets = []
Severity: Minor
Found in lib/steam_mist/rcon/pass.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language