redmine/redmine

View on GitHub
app/models/mail_handler.rb

Summary

Maintainability
F
4 days
Test Coverage

File mail_handler.rb has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MailHandler < ActionMailer::Base
  include ActionView::Helpers::SanitizeHelper
  include Redmine::I18n

  class UnauthorizedAction < StandardError; end
Severity: Major
Found in app/models/mail_handler.rb - About 1 day to fix

    Class MailHandler has 35 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class MailHandler < ActionMailer::Base
      include ActionView::Helpers::SanitizeHelper
      include Redmine::I18n
    
      class UnauthorizedAction < StandardError; end
    Severity: Minor
    Found in app/models/mail_handler.rb - About 4 hrs to fix

      Method receive has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def receive(email, options={})
          @email = email
          @handler_options = options
          sender_email = email.from.to_a.first.to_s.strip
          # Ignore emails received from the application emission address to avoid hell cycles
      Severity: Minor
      Found in app/models/mail_handler.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_project_from_receiver_addresses has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_project_from_receiver_addresses
          local, domain = handler_options[:project_from_subaddress].to_s.split("@")
          return nil unless local && domain
      
          local = Regexp.escape(local)
      Severity: Minor
      Found in app/models/mail_handler.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method receive has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def receive(email, options={})
          @email = email
          @handler_options = options
          sender_email = email.from.to_a.first.to_s.strip
          # Ignore emails received from the application emission address to avoid hell cycles
      Severity: Minor
      Found in app/models/mail_handler.rb - About 1 hr to fix

        Method new_user_from_attributes has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def new_user_from_attributes(email_address, fullname=nil)
              user = User.new
        
              # Truncating the email address would result in an invalid format
              user.mail = email_address
        Severity: Minor
        Found in app/models/mail_handler.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method receive_issue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def receive_issue
            project = target_project
        
            # Never receive emails to projects where adding issues is not possible
            raise NotAllowedInProject, "not possible to add issues to project [#{project.name}]" unless project.allows_to?(:add_issues)
        Severity: Minor
        Found in app/models/mail_handler.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_attachments has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def add_attachments(obj)
            if email.attachments && email.attachments.any?
              email.attachments.each do |attachment|
                next unless accept_attachment?(attachment)
                next unless attachment.body.decoded.size > 0
        Severity: Minor
        Found in app/models/mail_handler.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method plain_text_body has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def plain_text_body
            return @plain_text_body unless @plain_text_body.nil?
        
            parse_order =
              if Setting.mail_handler_preferred_body_part == 'html'
        Severity: Minor
        Found in app/models/mail_handler.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method receive_issue has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def receive_issue
            project = target_project
        
            # Never receive emails to projects where adding issues is not possible
            raise NotAllowedInProject, "not possible to add issues to project [#{project.name}]" unless project.allows_to?(:add_issues)
        Severity: Minor
        Found in app/models/mail_handler.rb - About 1 hr to fix

          Method dispatch has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def dispatch
              headers = [email.in_reply_to, email.references].flatten.compact
              subject = email.subject.to_s
              if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
                klass, object_id = $1, $2.to_i
          Severity: Minor
          Found in app/models/mail_handler.rb - About 1 hr to fix

            Method get_keyword has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def get_keyword(attr, options={})
                @keywords ||= {}
                if @keywords.has_key?(attr)
                  @keywords[attr]
                else
            Severity: Minor
            Found in app/models/mail_handler.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method dispatch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def dispatch
                headers = [email.in_reply_to, email.references].flatten.compact
                subject = email.subject.to_s
                if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
                  klass, object_id = $1, $2.to_i
            Severity: Minor
            Found in app/models/mail_handler.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cleanup_body has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def cleanup_body(body)
                delimiters = Setting.mail_handler_body_delimiters.to_s.split(/[\r\n]+/).reject(&:blank?)
            
                if Setting.mail_handler_enable_regex_delimiters?
                  begin
            Severity: Minor
            Found in app/models/mail_handler.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method receive_issue_reply has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def receive_issue_reply(issue_id, from_journal=nil)
                issue = Issue.find_by(:id => issue_id)
                if issue.nil?
                  raise MissingContainer, "reply to nonexistant issue [##{issue_id}]"
                end
            Severity: Minor
            Found in app/models/mail_handler.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method receive_message_reply has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def receive_message_reply(message_id)
                message = Message.find_by(:id => message_id)&.root
                if message.nil?
                  raise MissingContainer, "reply to nonexistant message [#{message_id}]"
                end
            Severity: Minor
            Found in app/models/mail_handler.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method extract_keyword! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def extract_keyword!(text, attr, format=nil)
                keys = [attr.to_s.humanize]
                if attr.is_a?(Symbol)
                  if user && user.language.present?
                    keys << l("field_#{attr}", :default => '', :locale =>  user.language)
            Severity: Minor
            Found in app/models/mail_handler.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_user_from_email has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def create_user_from_email
                if from_addr = email.header['from'].try(:addrs).to_a.first
                  addr = from_addr.address
                  name = from_addr.display_name || from_addr.comments.to_a.first
                  user = self.class.new_user_from_attributes(addr, name)
            Severity: Minor
            Found in app/models/mail_handler.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return false
            Severity: Major
            Found in app/models/mail_handler.rb - About 30 mins to fix

              Method accept_attachment? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def accept_attachment?(attachment)
                  @excluded ||= Setting.mail_handler_excluded_filenames.to_s.split(',').map(&:strip).reject(&:blank?)
                  @excluded.each do |pattern|
                    if Setting.mail_handler_enable_regex_excluded_filenames?
                      regexp = %r{\A#{pattern}\z}i
              Severity: Minor
              Found in app/models/mail_handler.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method receive_news_reply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def receive_news_reply(news_id)
                  news = News.find_by_id(news_id)
                  if news.nil?
                    raise MissingContainer, "reply to nonexistant news [#{news_id}]"
                  end
              Severity: Minor
              Found in app/models/mail_handler.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status