Sign upLogin

redmine/redmine

View on GitHub
Star
app/models/repository/subversion.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method fetch_changesets has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def fetch_changesets
    scm_info = scm.info
    if scm_info
      # latest revision found in database
      db_revision = latest_changeset ? latest_changeset.revision.to_i : 0
Severity: Minor
Found in app/models/repository/subversion.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch_changesets has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def fetch_changesets
    scm_info = scm.info
    if scm_info
      # latest revision found in database
      db_revision = latest_changeset ? latest_changeset.revision.to_i : 0
Severity: Minor
Found in app/models/repository/subversion.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                    unless changeset.new_record?
                  revision.paths.each do |change|
                    changeset.create_change(change)
                  end
                end
    Severity: Major
    Found in app/models/repository/subversion.rb - About 45 mins to fix

      Method load_entries_changesets has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def load_entries_changesets(entries)
    return unless entries

    entries_with_identifier =
      entries.select {|entry| entry.lastrev && entry.lastrev.identifier.present?}
      Severity: Minor
      Found in app/models/repository/subversion.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status