Sign upLogin

redmine/redmine

View on GitHub
Star
lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method find_events has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

          def find_events(event_type, user, from, to, options)
            provider_options = activity_provider_options[event_type]
            raise "#{self.name} can not provide #{event_type} events." if provider_options.nil?

            scope = provider_options[:scope]
Severity: Minor
Found in lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_events has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def find_events(event_type, user, from, to, options)
            provider_options = activity_provider_options[event_type]
            raise "#{self.name} can not provide #{event_type} events." if provider_options.nil?

            scope = provider_options[:scope]
Severity: Minor
Found in lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb - About 1 hr to fix

    Method find_events has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

              def find_events(event_type, user, from, to, options)
    Severity: Minor
    Found in lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb - About 35 mins to fix

      Method acts_as_activity_provider has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def acts_as_activity_provider(options = {})
          unless self.included_modules.include?(Redmine::Acts::ActivityProvider::InstanceMethods)
            cattr_accessor :activity_provider_options
            send :include, Redmine::Acts::ActivityProvider::InstanceMethods
          end
      Severity: Minor
      Found in lib/plugins/acts_as_activity_provider/lib/acts_as_activity_provider.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status