Sign upLogin

redmine/redmine

View on GitHub
Star
lib/redmine/scm/adapters/bazaar_adapter.rb

Summary

Maintainability
F
3 days
Test Coverage

Method revisions has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

        def revisions(path=nil, identifier_from=nil, identifier_to=nil, options={})
          path ||= ''
          identifier_from = (identifier_from and identifier_from.to_i > 0) ? identifier_from.to_i : 'last:1'
          identifier_to = (identifier_to and identifier_to.to_i > 0) ? identifier_to.to_i : 1
          revisions = Revisions.new
Severity: Minor
Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method entries has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        def entries(path=nil, identifier=nil, options={})
          path ||= ''
          entries = Entries.new
          identifier = -1 unless identifier && identifier.to_i > 0
          cmd_args = %w|ls -v --show-ids|
Severity: Minor
Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File bazaar_adapter.rb has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'redmine/scm/adapters/abstract_adapter'

module Redmine
  module Scm
    module Adapters
Severity: Minor
Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 3 hrs to fix

    Method revisions has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def revisions(path=nil, identifier_from=nil, identifier_to=nil, options={})
          path ||= ''
          identifier_from = (identifier_from and identifier_from.to_i > 0) ? identifier_from.to_i : 'last:1'
          identifier_to = (identifier_to and identifier_to.to_i > 0) ? identifier_to.to_i : 1
          revisions = Revisions.new
    Severity: Major
    Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 2 hrs to fix

      Method append_revisions_only has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

              def append_revisions_only
          return @aro unless @aro.nil?

          @aro = false
          bcp = self.class.branch_conf_path(url)
      Severity: Minor
      Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method entries has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def entries(path=nil, identifier=nil, options={})
          path ||= ''
          entries = Entries.new
          identifier = -1 unless identifier && identifier.to_i > 0
          cmd_args = %w|ls -v --show-ids|
      Severity: Minor
      Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 1 hr to fix

        Method append_revisions_only has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def append_revisions_only
          return @aro unless @aro.nil?

          @aro = false
          bcp = self.class.branch_conf_path(url)
        Severity: Minor
        Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 1 hr to fix

          Method annotate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                  def annotate(path, identifier=nil)
          blame = Annotate.new
          cmd_args = %w|annotate -q --all|
          cmd_args << "-r#{identifier.to_i}" if identifier && identifier.to_i > 0
          cmd_args << bzr_target(path)
          Severity: Minor
          Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                case parsing
                      when 'added'
                        revision.paths << {:action => 'A', :path => "/#{path}", :revision => revid}
                      when 'modified'
                        revision.paths << {:action => 'M', :path => "/#{path}", :revision => revid}
          Severity: Major
          Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 45 mins to fix

            Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    def initialize(url, root_url=nil, login=nil, password=nil, path_encoding=nil)
            Severity: Minor
            Found in lib/redmine/scm/adapters/bazaar_adapter.rb - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      class << self
          def client_command
            @@bin    ||= BZR_BIN
          end
              Severity: Major
              Found in lib/redmine/scm/adapters/bazaar_adapter.rb and 1 other location - About 1 hr to fix
              lib/redmine/scm/adapters/git_adapter.rb on lines 36..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          io.each_line do |line|
              next unless line =~ %r{^(\d+) ([^|]+)\| (.*)$}

              rev = $1
              blame.
              Severity: Minor
              Found in lib/redmine/scm/adapters/bazaar_adapter.rb and 1 other location - About 15 mins to fix
              lib/redmine/scm/adapters/subversion_adapter.rb on lines 257..267

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status