Sign upLogin

redmine/redmine

View on GitHub
Star
lib/redmine/scm/adapters/cvs_adapter.rb

Summary

Maintainability
F
4 days
Test Coverage

Method revisions has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

        def revisions(path=nil, identifier_from=nil, identifier_to=nil, options={}, &block)
          path_with_project_utf8   = path_with_proj(path)
          path_with_project_locale = scm_iconv(@path_encoding, 'UTF-8', path_with_project_utf8)
          logger.debug "<cvs> revisions path:" +
              "'#{path}',identifier_from #{identifier_from}, identifier_to #{identifier_to}"
Severity: Minor
Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File cvs_adapter.rb has 376 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'redmine/scm/adapters/abstract_adapter'

module Redmine
  module Scm
    module Adapters
Severity: Minor
Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 5 hrs to fix

    Method revisions has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def revisions(path=nil, identifier_from=nil, identifier_to=nil, options={}, &block)
          path_with_project_utf8   = path_with_proj(path)
          path_with_project_locale = scm_iconv(@path_encoding, 'UTF-8', path_with_project_utf8)
          logger.debug "<cvs> revisions path:" +
              "'#{path}',identifier_from #{identifier_from}, identifier_to #{identifier_to}"
    Severity: Major
    Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 4 hrs to fix

      Method entries has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

              def entries(path=nil, identifier=nil, options={})
          logger.debug "<cvs> entries '#{path}' with identifier '#{identifier}'"
          path_locale = scm_iconv(@path_encoding, 'UTF-8', path)
          path_locale = path_locale.b
          entries = Entries.new
      Severity: Minor
      Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class CvsAdapter has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

            class CvsAdapter < AbstractAdapter

        # CVS executable name
        CVS_BIN = Redmine::Configuration['scm_cvs_command'] || "cvs"
      Severity: Minor
      Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 2 hrs to fix

        Method entries has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def entries(path=nil, identifier=nil, options={})
          logger.debug "<cvs> entries '#{path}' with identifier '#{identifier}'"
          path_locale = scm_iconv(@path_encoding, 'UTF-8', path)
          path_locale = path_locale.b
          entries = Entries.new
        Severity: Major
        Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 2 hrs to fix

          Method annotate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

                  def annotate(path, identifier=nil)
          identifier = (identifier) ? identifier : "HEAD"
          logger.debug "<cvs> annotate path:'#{path}',identifier #{identifier}"
          cmd_args = %w|rannotate|
          cmd_args << "-D" << time_to_cvstime(identifier) if identifier
          Severity: Minor
          Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                          if line.start_with?(ENDLOG, STARTLOG)
                  if revision
                    revHelper = CvsRevisionHelper.new(revision)
                    revBranch = "HEAD"
                    branch_map.each() do |branch_name, branch_point|
          Severity: Major
          Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            if /^branches: (.+)$/.match?(line)
                  # TODO: version.branch = $1
                elsif /^revision (\d+(?:\.\d+)+).*$/ =~ line
                  revision = $1
                elsif /^date:\s+(\d+.\d+.\d+\s+\d+:\d+:\d+)/ =~ line
            Severity: Major
            Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 45 mins to fix

              Method revisions has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      def revisions(path=nil, identifier_from=nil, identifier_to=nil, options={}, &block)
              Severity: Minor
              Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 35 mins to fix

                Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def initialize(url, root_url=nil, login=nil, password=nil,
                       path_encoding=nil)
                Severity: Minor
                Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 35 mins to fix

                  Method cat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def cat(path, identifier=nil)
          identifier = (identifier) ? identifier : "HEAD"
          logger.debug "<cvs> cat path:'#{path}',identifier #{identifier}"
          cmd_args = %w|-q co|
          cmd_args << "-D" << time_to_cvstime(identifier) if identifier
                  Severity: Minor
                  Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method buildRevision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def buildRevision(rev)
          if rev == 0
            if @branchid.nil?
              @base + ".0"
            else
                  Severity: Minor
                  Found in lib/redmine/scm/adapters/cvs_adapter.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          class << self
          def client_command
            @@bin    ||= CVS_BIN
          end
                  Severity: Major
                  Found in lib/redmine/scm/adapters/cvs_adapter.rb and 1 other location - About 1 hr to fix
                  lib/redmine/scm/adapters/subversion_adapter.rb on lines 30..57

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status