lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb
Method customize_allowlist has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
Open
def customize_allowlist(allowlist)
# Disallow `name` attribute globally, allow on `a`
allowlist[:attributes][:all].delete("name")
allowlist[:attributes]["a"].push("name")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method customize_allowlist has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def customize_allowlist(allowlist)
# Disallow `name` attribute globally, allow on `a`
allowlist[:attributes][:all].delete("name")
allowlist[:attributes]["a"].push("name")
Avoid too many return statements within this method. Open
Open
return unless RELAXED_PROTOCOL_ATTRS.include?(name)Avoid too many return statements within this method. Open
Open
return if node.name == "li" && node["id"] =~ /\Afn-\d+\z/Avoid too many return statements within this method. Open
Open
return if node.type != Nokogiri::XML::Node::ELEMENT_NODEAvoid too many return statements within this method. Open
Open
return if node.name == "a" && node["id"] =~ /\Afnref-\d+\z/