Sign upLogin

reevoo/sapience-rb

View on GitHub
Star

Showing 1,401 of 1,401 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          content_type = env["CONTENT_TYPE"] || env["CONTENT-TYPE"]
Severity: Minor
Found in lib/sapience/extensions/grape/request_format_helper.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Add an empty line after magic comments.
Open

require "action_controller/log_subscriber"
Severity: Minor
Found in lib/sapience/extensions/action_controller/log_subscriber.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Line is too long. [83/80]
Open

          if ::ActionPack::VERSION::MAJOR == 3 && ::ActionPack::VERSION::MINOR == 0
Severity: Minor
Found in lib/sapience/extensions/action_controller/log_subscriber.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "action_controller/log_subscriber"
Severity: Minor
Found in lib/sapience/extensions/action_controller/log_subscriber.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Avoid comma after the last item of a hash.
Open

            db: event.payload[:db_runtime],
Severity: Minor
Found in lib/sapience/extensions/action_controller/log_subscriber.rb by rubocop

This cop checks for trailing comma in array and hash literals.

Example: EnforcedStyleForMultiline: consistent_comma

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: comma

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: no_comma (default)

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Line is too long. [100/80]
Open

                Sapience.metrics.increment(self.class.const_get(:SAPIENCE_MODEL_UPDATE_METRICS_KEY))
Severity: Minor
Found in lib/sapience/extensions/active_record/model_metrics.rb by rubocop

Line is too long. [94/80]
Open

        def record(event) # rubocop:disable AbcSize, CyclomaticComplexity, PerceivedComplexity
Severity: Minor
Found in lib/sapience/extensions/active_record/notifications.rb by rubocop

Extra empty line detected at class body beginning.
Open


  if Rails::VERSION::MAJOR == 3 && ::Sapience.config.silent_rack
Severity: Minor
Found in lib/sapience/extensions/rails/rack/logger_info_as_debug.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Add an empty line after magic comments.
Open

# Log actual exceptions, not a string representation
Severity: Minor
Found in lib/sapience/extensions/action_dispatch/debug_exceptions.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Missing top-level class documentation comment.
Open

class ActionDispatch::DebugExceptions # rubocop:disable ClassAndModuleChildren
Severity: Minor
Found in lib/sapience/extensions/action_dispatch/debug_exceptions.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

              ip: (request.env["HTTP_X_FORWARDED_FOR"] || request.env["REMOTE_ADDR"]),
Severity: Minor
Found in lib/sapience/extensions/grape/middleware/info_builder.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [87/80]
Open

          Sapience::Extensions::Notifications.subscribe "endpoint_run.grape" do |event|
Severity: Minor
Found in lib/sapience/extensions/grape/notifications.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          @metric_name = options[:metric_name] || "rails.request"
Severity: Minor
Found in lib/sapience/extensions/action_controller/notifications.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Avoid comma after the last item of a hash.
Open

            params: payload[:params],
Severity: Minor
Found in lib/sapience/extensions/action_controller/log_subscriber.rb by rubocop

This cop checks for trailing comma in array and hash literals.

Example: EnforcedStyleForMultiline: consistent_comma

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: comma

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: no_comma (default)

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Line is too long. [92/80]
Open

            const_set(:SAPIENCE_MODEL_CREATE_METRICS_KEY,  "model.#{tableized_name}.create")
Severity: Minor
Found in lib/sapience/extensions/active_record/model_metrics.rb by rubocop

Line is too long. [100/80]
Open

                Sapience.metrics.increment(self.class.const_get(:SAPIENCE_MODEL_CREATE_METRICS_KEY))
Severity: Minor
Found in lib/sapience/extensions/active_record/model_metrics.rb by rubocop

Line is too long. [89/80]
Open

        # *<tt>:include_generic</tt>  - record general (nameless) queries, off by default
Severity: Minor
Found in lib/sapience/extensions/active_record/notifications.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          @metric_name     = opts[:metric_name] || "activerecord.sql"
Severity: Minor
Found in lib/sapience/extensions/active_record/notifications.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing top-level module documentation comment.
Open

module ActiveModelSerializers::Logging # rubocop:disable ClassAndModuleChildren
Severity: Minor
Found in lib/sapience/extensions/active_model_serializers/logging.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at class body end.
Open


        end
Severity: Minor
Found in lib/sapience/extensions/sinatra/middleware/logging.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end
Severity
Category
Status
Source
Language