Sign upLogin

refinery29/newrelic

View on GitHub
Star

Showing 55 of 55 total issues

File AgentTest.php has 574 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
 * Copyright (c) 2016 Refinery29, Inc.
 *
Severity: Major
Found in test/AgentTest.php - About 1 day to fix

    AgentTest has 55 functions (exceeds 20 allowed). Consider refactoring.
    Open

    final class AgentTest extends \PHPUnit_Framework_TestCase
{
    use TestHelper;

    public function testImplementsAgentInterface()
    Severity: Major
    Found in test/AgentTest.php - About 7 hrs to fix

      The class AgentTest has 53 public methods. Consider refactoring AgentTest to keep number of public methods under 10.
      Open

      final class AgentTest extends \PHPUnit_Framework_TestCase
{
    use TestHelper;

    public function testImplementsAgentInterface()
      Severity: Minor
      Found in test/AgentTest.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class AgentTest has 55 non-getter- and setter-methods. Consider refactoring AgentTest to keep number of methods under 25.
      Open

      final class AgentTest extends \PHPUnit_Framework_TestCase
{
    use TestHelper;

    public function testImplementsAgentInterface()
      Severity: Minor
      Found in test/AgentTest.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class Agent has 15 public methods. Consider refactoring Agent to keep number of public methods under 10.
      Open

      final class Agent implements AgentInterface
{
    /**
     * @var Handler
     */
      Severity: Minor
      Found in src/Agent.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class AgentTest has an overall complexity of 56 which is very high. The configured complexity threshold is 50.
      Open

      final class AgentTest extends \PHPUnit_Framework_TestCase
{
    use TestHelper;

    public function testImplementsAgentInterface()
      Severity: Minor
      Found in test/AgentTest.php by phpmd

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function testCustomMetric()
    {
        $faker = $this->getFaker();

        $name = $faker->word;
      Severity: Major
      Found in test/AgentTest.php and 1 other location - About 1 hr to fix
      test/AgentTest.php on lines 921..942

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function testStartTransaction()
    {
        $faker = $this->getFaker();

        $name = $faker->word;
      Severity: Major
      Found in test/AgentTest.php and 1 other location - About 1 hr to fix
      test/AgentTest.php on lines 311..332

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      The class AgentTest has 53 public methods and attributes. Consider reducing the number of public items to less than 45.
      Open

      final class AgentTest extends \PHPUnit_Framework_TestCase
{
    use TestHelper;

    public function testImplementsAgentInterface()
      Severity: Minor
      Found in test/AgentTest.php by phpmd

      ExcessivePublicCount

      Since: 0.1

      A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.

      Example

      public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

      Source https://phpmd.org/rules/codesize.html#excessivepubliccount

      The method endTransaction has a boolean flag argument $ignore, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function endTransaction($ignore = false)
      Severity: Minor
      Found in src/Agent.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method endTransaction has a boolean flag argument $ignore, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function endTransaction($ignore = false);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getBrowserTimingFooter has a boolean flag argument $includeTags, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getBrowserTimingFooter($includeTags = false);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method setAppname has a boolean flag argument $xmit, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function setAppname($name, $license = '', $xmit = false);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method backgroundJob has a boolean flag argument $flag, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function backgroundJob($flag = true)
      Severity: Minor
      Found in src/Agent.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method captureParams has a boolean flag argument $enable, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function captureParams($enable = true);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method setAppname has a boolean flag argument $xmit, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function setAppname($name, $license = '', $xmit = false)
      Severity: Minor
      Found in src/Agent.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method backgroundJob has a boolean flag argument $flag, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function backgroundJob($flag = true);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getBrowserTimingHeader has a boolean flag argument $includeTags, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getBrowserTimingHeader($includeTags = false);
      Severity: Minor
      Found in src/AgentInterface.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getBrowserTimingHeader has a boolean flag argument $includeTags, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getBrowserTimingHeader($includeTags = false)
      Severity: Minor
      Found in src/Agent.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getBrowserTimingFooter has a boolean flag argument $includeTags, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getBrowserTimingFooter($includeTags = false)
      Severity: Minor
      Found in src/Agent.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Severity
      Category
      Status
      Source
      Language