Sign upLogin

regevbr/json-expression-eval

View on GitHub
Star
src/lib/evaluator.ts

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Function evaluateCompareOp has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Wontfix

async function evaluateCompareOp<C extends Context, Ignore>(expressionValue: ExtendedCompareOp<any, any, any>,
                                                            expressionKey: string, contextValue: any,
                                                            context: C, validation: boolean)
    : Promise<boolean> {
    if (!_isObject(expressionValue)) {
Severity: Minor
Found in src/lib/evaluator.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function evaluateCompareOp has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

async function evaluateCompareOp<C extends Context, Ignore>(expressionValue: ExtendedCompareOp<any, any, any>,
                                                            expressionKey: string, contextValue: any,
                                                            context: C, validation: boolean)
    : Promise<boolean> {
    if (!_isObject(expressionValue)) {
Severity: Major
Found in src/lib/evaluator.ts - About 2 hrs to fix

    Function run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

    async function run<C extends Context, F extends FunctionsTable<C, CustomEvaluatorFuncRunOptions>,
    Ignore, CustomEvaluatorFuncRunOptions>(
        expression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>, context: C,
        functionsTable: F, validation: boolean, runOptions: CustomEvaluatorFuncRunOptions): Promise<boolean> {
    const expressionKeys = objectKeys(expression);
    Severity: Minor
    Found in src/lib/evaluator.ts - About 1 hr to fix

      Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Invalid

      async function run<C extends Context, F extends FunctionsTable<C, CustomEvaluatorFuncRunOptions>,
    Ignore, CustomEvaluatorFuncRunOptions>(
        expression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>, context: C,
        functionsTable: F, validation: boolean, runOptions: CustomEvaluatorFuncRunOptions): Promise<boolean> {
    const expressionKeys = objectKeys(expression);
      Severity: Minor
      Found in src/lib/evaluator.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

              expression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>, context: C,
        functionsTable: F, validation: boolean, runOptions: CustomEvaluatorFuncRunOptions): Promise<boolean> {
      Severity: Minor
      Found in src/lib/evaluator.ts - About 35 mins to fix

        Function handleOrOp has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

                orExpression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>[],
        context: C, functionsTable: F, validation: boolean, runOptions: CustomEvaluatorFuncRunOptions)
        Severity: Minor
        Found in src/lib/evaluator.ts - About 35 mins to fix

          Function evaluateCompareOp has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          async function evaluateCompareOp<C extends Context, Ignore>(expressionValue: ExtendedCompareOp<any, any, any>,
                                                            expressionKey: string, contextValue: any,
                                                            context: C, validation: boolean)
          Severity: Minor
          Found in src/lib/evaluator.ts - About 35 mins to fix

            Function handleAndOp has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Wontfix

            (andExpression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>[], context: C, functionsTable: F,
 validation: boolean, runOptions: CustomEvaluatorFuncRunOptions): Promise<boolean> {
            Severity: Minor
            Found in src/lib/evaluator.ts - About 35 mins to fix

              Avoid too many return statements within this function.
              Wontfix

                      return contextValue >= low && contextValue <= high;
              Severity: Major
              Found in src/lib/evaluator.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return expressionValue.nin.map((value) => computeValue(context, validation, value, expressionKey))
            .indexOf(contextValue) < 0;
                Severity: Major
                Found in src/lib/evaluator.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Wontfix

                          return assertUnreachable(expressionValue, `Invalid expression - unknown op ${compareKeys[0]}`);
                  Severity: Major
                  Found in src/lib/evaluator.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return evaluateCompareOp<C, Ignore>(
            (expression as PropertyCompareOps<C, Ignore>)
                [expressionKey as any as keyof PropertyCompareOps<C, Ignore>] as
                unknown as ExtendedCompareOp<any, any, any>,
            expressionKey, contextValue, context, validation);
                    Severity: Major
                    Found in src/lib/evaluator.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return contextValue > gtValue;
                      Severity: Major
                      Found in src/lib/evaluator.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return Boolean(contextValue.match(new RegExp(regexpiValue, `i`)));
                        Severity: Major
                        Found in src/lib/evaluator.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return contextValue < ltValue;
                          Severity: Major
                          Found in src/lib/evaluator.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return Boolean(contextValue.match(new RegExp(regexpValue)));
                            Severity: Major
                            Found in src/lib/evaluator.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return contextValue >= gteValue;
                              Severity: Major
                              Found in src/lib/evaluator.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return contextValue <= lteValue;
                                Severity: Major
                                Found in src/lib/evaluator.ts - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Wontfix

                                  async function handleOrOp<C extends Context, F extends FunctionsTable<C, CustomEvaluatorFuncRunOptions>,
    Ignore, CustomEvaluatorFuncRunOptions>(
        orExpression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>[],
        context: C, functionsTable: F, validation: boolean, runOptions: CustomEvaluatorFuncRunOptions)
    : Promise<boolean> {
                                  Severity: Minor
                                  Found in src/lib/evaluator.ts and 1 other location - About 50 mins to fix
                                  src/lib/evaluator.ts on lines 150..165

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 51.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Wontfix

                                  async function handleAndOp<C extends Context, F extends FunctionsTable<C, CustomEvaluatorFuncRunOptions>,
    Ignore, CustomEvaluatorFuncRunOptions>
(andExpression: Expression<C, F, Ignore, CustomEvaluatorFuncRunOptions>[], context: C, functionsTable: F,
 validation: boolean, runOptions: CustomEvaluatorFuncRunOptions): Promise<boolean> {
    if (andExpression.length === 0) {
                                  Severity: Minor
                                  Found in src/lib/evaluator.ts and 1 other location - About 50 mins to fix
                                  src/lib/evaluator.ts on lines 167..183

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 51.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                      } else if (isLteCompareOp(expressionValue)) {
        contextNumberAssertion(expressionKey, contextValue);
        const lteValue = computeValue(context, validation, expressionValue.lte, expressionKey);
        expressionNumberAssertion(expressionKey, lteValue);
        return contextValue <= lteValue;
                                  Severity: Major
                                  Found in src/lib/evaluator.ts and 3 other locations - About 30 mins to fix
                                  src/lib/evaluator.ts on lines 111..147
                                  src/lib/evaluator.ts on lines 116..147
                                  src/lib/evaluator.ts on lines 126..147

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                      } else if (isGteCompareOp(expressionValue)) {
        contextNumberAssertion(expressionKey, contextValue);
        const gteValue = computeValue(context, validation, expressionValue.gte, expressionKey);
        expressionNumberAssertion(expressionKey, gteValue);
        return contextValue >= gteValue;
                                  Severity: Major
                                  Found in src/lib/evaluator.ts and 3 other locations - About 30 mins to fix
                                  src/lib/evaluator.ts on lines 111..147
                                  src/lib/evaluator.ts on lines 121..147
                                  src/lib/evaluator.ts on lines 126..147

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                      } else if (isGtCompareOp(expressionValue)) {
        contextNumberAssertion(expressionKey, contextValue);
        const gtValue = computeValue(context, validation, expressionValue.gt, expressionKey);
        expressionNumberAssertion(expressionKey, gtValue);
        return contextValue > gtValue;
                                  Severity: Major
                                  Found in src/lib/evaluator.ts and 3 other locations - About 30 mins to fix
                                  src/lib/evaluator.ts on lines 116..147
                                  src/lib/evaluator.ts on lines 121..147
                                  src/lib/evaluator.ts on lines 126..147

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 4 locations. Consider refactoring.
                                  Open

                                      } else if (isLtCompareOp(expressionValue)) {
        contextNumberAssertion(expressionKey, contextValue);
        const ltValue = computeValue(context, validation, expressionValue.lt, expressionKey);
        expressionNumberAssertion(expressionKey, ltValue);
        return contextValue < ltValue;
                                  Severity: Major
                                  Found in src/lib/evaluator.ts and 3 other locations - About 30 mins to fix
                                  src/lib/evaluator.ts on lines 111..147
                                  src/lib/evaluator.ts on lines 116..147
                                  src/lib/evaluator.ts on lines 121..147

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 45.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status