Sign upLogin

relaton/relaton-ecma

View on GitHub
Star

Showing 3 of 3 total issues

Class DataParser has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class DataParser
    MATTRS = %i[docid title date link doctype].freeze
    ATTRS = MATTRS + %i[abstract relation edition doctype].freeze

    #
Severity: Minor
Found in lib/relaton_ecma/data_parser.rb - About 2 hrs to fix

    Method parse_editions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_editions # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
      return [] unless @doc

      docid = @bib[:docid]
      @doc.xpath('//div[@id="main"]/div[1]/div/main/article/div/div/standard/div/ul/li').map do |hit|
    Severity: Minor
    Found in lib/relaton_ecma/data_parser.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetch_doc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def fetch_doc(code) # rubocop:disable Metrics/AbcSize
        row = search(code).min { |a, b| compare_edition_volume a, b }
        return unless row

        url = "#{ENDPOINT}#{row[:file]}"
    Severity: Minor
    Found in lib/relaton_ecma/ecma_bibliography.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language