Sign upLogin

relaton/relaton-ietf

View on GitHub
Star
lib/relaton_ietf/ietf_bibliographic_item.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method to_xml has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml(**opts) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
      opts[:date_format] ||= :short
      super(**opts) do |builder|
        if opts[:bibdata] && (doctype || editorialgroup || ics&.any? ||
          structuredidentifier&.presence? || stream)
Severity: Minor
Found in lib/relaton_ietf/ietf_bibliographic_item.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if opts[:bibdata] && (doctype || editorialgroup || ics&.any? ||
          structuredidentifier&.presence? || stream)
          ext = builder.ext do |b|
            doctype&.to_xml b
            b.subdoctype subdoctype if subdoctype
Severity: Major
Found in lib/relaton_ietf/ietf_bibliographic_item.rb - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status