Sign upLogin

remotestorage/remotestorage-server

View on GitHub
Star

Showing 45 of 45 total issues

Function revisionsToMap has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.prototype.revisionsToMap = function(revisions, username, path, cb) {
  var i, items = {}, todo = 1, error, errorSent;
  function doneOne() {
    if (error) {
      if (!errorSent) {
Severity: Minor
Found in lib/main.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

module.exports.prototype.set = function(username, path, dataBuf, contentType, revision, cb) {
  this.dataStore.set(username, 'content:' + path, dataBuf, function(err1) {
    if (err1) {
      cb(err1);
      return;
Severity: Minor
Found in lib/main.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkCondMet has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

module.exports.prototype.checkCondMet = function(req, res, username, path, statusCode, cb, release) {
Severity: Major
Found in lib/requests.js - About 50 mins to fix

    Function checkFound has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports.prototype.checkFound = function(req, res, username, path, folder404s, cb, release) {
    Severity: Major
    Found in lib/requests.js - About 50 mins to fix

      Function doGet has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      module.exports.prototype.doGet = function(req, res, release, username, path, folderFormat, folderContentType) {
      Severity: Major
      Found in lib/requests.js - About 50 mins to fix

        Function set has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        module.exports.prototype.set = function(username, path, dataBuf, contentType, revision, cb) {
        Severity: Minor
        Found in lib/main.js - About 45 mins to fix

          Function getWebfingerLink has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports.prototype.getWebfingerLink = function(protocol, host, port, userName, authUrl, webAuthoring) {
          Severity: Minor
          Found in lib/remotestorage-server.js - About 45 mins to fix

            Function checkNoFolder has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            module.exports.prototype.checkNoFolder = function(req, res, username, path, cb, release) {
            Severity: Minor
            Found in lib/requests.js - About 45 mins to fix

              Function writeHead has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              module.exports.prototype.writeHead = function(res, status, origin, revision, contentType, contentLength) {
              Severity: Minor
              Found in lib/requests.js - About 45 mins to fix

                Function writeRaw has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                module.exports.prototype.writeRaw = function(res, contentType, content, origin, revision, explicitLength) {
                Severity: Minor
                Found in lib/requests.js - About 45 mins to fix

                  Function doHead has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  module.exports.prototype.doHead = function(req, res, release, username, path, folderContentType) {
                  Severity: Minor
                  Found in lib/requests.js - About 45 mins to fix

                    Function checkMayWrite has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    module.exports.prototype.checkMayWrite = function(req, res, username, path, cb, release) {
                    Severity: Minor
                    Found in lib/requests.js - About 45 mins to fix

                      Function checkFound has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      module.exports.prototype.checkFound = function(req, res, username, path, folder404s, cb, release) {
  if (path.substr(-1) === '/' && !folder404s) {//folders always exist in new spec versions
    cb();
  } else {
    this.mainInstance.exists(username, path, function(err, answer) {
                      Severity: Minor
                      Found in lib/requests.js - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function may has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      module.exports.prototype.may = function(authorizationHeader, username, path, write, cb) {
  var i, scopeParts, scopes, pathParts;
  if (write && path.substr(-1) === '/') {
    cb(null, false);
  } else if (path[0] !== '/' || username.length === 0) {
                      Severity: Minor
                      Found in lib/scopes.js - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function checkMayRead has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      module.exports.prototype.checkMayRead = function(req, res, username, path, cb, release) {
                      Severity: Minor
                      Found in lib/requests.js - About 45 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        module.exports.prototype.getContent = function(username, path, cb) {
  this.dataStore.get(username, 'content:' + path, cb);
};
                        Severity: Minor
                        Found in lib/main.js and 1 other location - About 40 mins to fix
                        lib/main.js on lines 154..156

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        module.exports.prototype.getContentType = function(username, path, cb) {
  this.dataStore.get(username, 'contentType:' + path, cb);
};
                        Severity: Minor
                        Found in lib/main.js and 1 other location - About 40 mins to fix
                        lib/main.js on lines 151..153

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function may has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        module.exports.prototype.may = function(authorizationHeader, username, path, write, cb) {
                        Severity: Minor
                        Found in lib/scopes.js - About 35 mins to fix

                          Function doDelete has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          module.exports.prototype.doDelete = function(req, res, release, username, path) {
                          Severity: Minor
                          Found in lib/requests.js - About 35 mins to fix

                            Function backdoorSet has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            module.exports.prototype.backdoorSet = function(username, path, body, contentType, cb) {
                            Severity: Minor
                            Found in lib/remotestorage-server.js - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language