Sign upLogin

renalreg/radar

View on GitHub
Star
radar/api/views/group_patients.py

Summary

Maintainability
C
1 day
Test Coverage

Function update_system_groups has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def update_system_groups(patient):
    """Check that patient system group still has some children groups."""

    systems = patient.systems
    if len(systems) == 1:
Severity: Minor
Found in radar/api/views/group_patients.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

def register_views(app):
    app.add_url_rule('/group-patients', view_func=GroupPatientListView.as_view('group_patient_list'))
    app.add_url_rule('/group-patients', view_func=GroupPatientCreateView.as_view('group_patient_create'))
    app.add_url_rule('/group-patients/<int:id>', view_func=GroupPatientRetrieveView.as_view('group_patient_retrieve'))
    app.add_url_rule('/group-patients/<int:id>', view_func=GroupPatientUpdateView.as_view('group_patient_update'))
Severity: Major
Found in radar/api/views/group_patients.py and 4 other locations - About 6 hrs to fix
radar/api/views/forms.py on lines 204..209
radar/api/views/group_users.py on lines 58..63
radar/api/views/nephrectomies.py on lines 38..49
radar/api/views/pregnancies.py on lines 32..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class GroupPatientListView(ListModelView):
    serializer_class = GroupPatientSerializer
    model_class = GroupPatient

    def filter_query(self, query):
Severity: Major
Found in radar/api/views/group_patients.py and 1 other location - About 3 hrs to fix
radar/api/views/group_users.py on lines 23..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status