Sign upLogin

renalreg/radar

View on GitHub
Star
radar/recruitment/__init__.py

Summary

Maintainability
C
1 day
Test Coverage

File __init__.py has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from asyncio import protocols
import calendar
from datetime import datetime
import itertools
import logging
Severity: Minor
Found in radar/recruitment/__init__.py - About 3 hrs to fix

    Function _create_patient has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def _create_patient(self):
        logger.info("Creating patient number={}".format(self.number))

        system_group = self.cohort_group.parent_group
        patient = Patient()
    Severity: Minor
    Found in radar/recruitment/__init__.py - About 1 hr to fix

      Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(
      Severity: Major
      Found in radar/recruitment/__init__.py - About 50 mins to fix

        Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Major
        Found in radar/recruitment/__init__.py - About 50 mins to fix

          Function _check_date_of_birth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def _check_date_of_birth(self, patient):
        dates_of_birth = patient.dates_of_birth

        if len(dates_of_birth) == 0:
            return True
          Severity: Minor
          Found in radar/recruitment/__init__.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(
        self,
        search_patient,
        cohort_group,
        hospital_group,
          Severity: Major
          Found in radar/recruitment/__init__.py and 1 other location - About 2 hrs to fix
          radar/recruitment/__init__.py on lines 42..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(
        self,
        first_name,
        last_name,
        date_of_birth,
          Severity: Major
          Found in radar/recruitment/__init__.py and 1 other location - About 2 hrs to fix
          radar/recruitment/__init__.py on lines 204..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status