Sign upLogin

renalreg/radar

View on GitHub
Star
radar/ukrdc_exporter/group_selector.py

Summary

Maintainability
D
2 days
Test Coverage

Consider simplifying this complex logical expression.
Open

        if a.to_date is None and b.to_date is not None:
            return a
        elif b.to_date is None and a.to_date is not None:
            return b
        elif a.to_date is not None and b.to_date is not None and a.to_date > b.to_date:
Severity: Major
Found in radar/ukrdc_exporter/group_selector.py - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if a.from_date < b.from_date:
            return a
        elif b.from_date < a.from_date:
            return b
        elif a.to_date is None and b.to_date is not None:
    Severity: Major
    Found in radar/ukrdc_exporter/group_selector.py - About 1 hr to fix

      Function _select_present has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def _select_present(self, a, b):
        """Return the membership with the latest to date.

        Settle ties using the earliest from date and then the newest membership (by ID).
        """
      Severity: Minor
      Found in radar/ukrdc_exporter/group_selector.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _select_future has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _select_future(self, a, b):
        """Return the membership with the earliest from date.

        Settle ties using the latest to date and then the newest membership (by ID).
        """
      Severity: Minor
      Found in radar/ukrdc_exporter/group_selector.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return a
      Severity: Major
      Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return a
        Severity: Major
        Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return a
          Severity: Major
          Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return b
            Severity: Major
            Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return b
              Severity: Major
              Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return b
                Severity: Major
                Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return b
                  Severity: Major
                  Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return a
                    Severity: Major
                    Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return a
                      Severity: Major
                      Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return b
                        Severity: Major
                        Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return self._select_future(membership_a, membership_b)
                          Severity: Major
                          Found in radar/ukrdc_exporter/group_selector.py - About 30 mins to fix

                            Function _select_past has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                def _select_past(self, a, b):
        """Return the membership with the latest to date.

        Settle ties using the newest membership (by ID).
        """
                            Severity: Minor
                            Found in radar/ukrdc_exporter/group_selector.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    elif b.to_date > a.to_date:
            return b
        elif a.from_date < b.from_date:
            return a
        elif b.from_date < a.from_date:
                            Severity: Major
                            Found in radar/ukrdc_exporter/group_selector.py and 1 other location - About 2 hrs to fix
                            radar/ukrdc_exporter/group_selector.py on lines 60..69

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 57.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    elif a.to_date is not None and b.to_date is not None and b.to_date > a.to_date:
            return b
        elif a.from_date < b.from_date:
            return a
        elif b.from_date < a.from_date:
                            Severity: Major
                            Found in radar/ukrdc_exporter/group_selector.py and 1 other location - About 2 hrs to fix
                            radar/ukrdc_exporter/group_selector.py on lines 37..46

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 57.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                    elif a.to_date is not None and b.to_date is not None and a.to_date > b.to_date:
                            Severity: Major
                            Found in radar/ukrdc_exporter/group_selector.py and 3 other locations - About 35 mins to fix
                            radar/ukrdc_exporter/group_selector.py on lines 58..58
                            radar/ukrdc_exporter/group_selector.py on lines 60..60
                            radar/ukrdc_exporter/group_selector.py on lines 87..87

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 33.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                    elif a.to_date is not None and b.to_date is not None and b.to_date > a.to_date:
                            Severity: Major
                            Found in radar/ukrdc_exporter/group_selector.py and 3 other locations - About 35 mins to fix
                            radar/ukrdc_exporter/group_selector.py on lines 58..58
                            radar/ukrdc_exporter/group_selector.py on lines 60..60
                            radar/ukrdc_exporter/group_selector.py on lines 85..85

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 33.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                    elif a.to_date is not None and b.to_date is not None and a.to_date > b.to_date:
                            Severity: Major
                            Found in radar/ukrdc_exporter/group_selector.py and 3 other locations - About 35 mins to fix
                            radar/ukrdc_exporter/group_selector.py on lines 60..60
                            radar/ukrdc_exporter/group_selector.py on lines 85..85
                            radar/ukrdc_exporter/group_selector.py on lines 87..87

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 33.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status