renoki-co/php-k8s

View on GitHub
src/Instances/Container.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Container has an overall complexity of 50 which is very high. The configured complexity threshold is 50.
Open

class Container extends Instance
{
    /**
     * Set the image for the container.
     *
Severity: Minor
Found in src/Instances/Container.php by phpmd

The class Container has 15 public methods. Consider refactoring Container to keep number of public methods under 10.
Open

class Container extends Instance
{
    /**
     * Set the image for the container.
     *
Severity: Minor
Found in src/Instances/Container.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The method getStartupProbe has a boolean flag argument $asInstance, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getStartupProbe(bool $asInstance = true)
Severity: Minor
Found in src/Instances/Container.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getMountedVolumes has a boolean flag argument $asInstance, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getMountedVolumes(bool $asInstance = true)
Severity: Minor
Found in src/Instances/Container.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getLivenessProbe has a boolean flag argument $asInstance, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getLivenessProbe(bool $asInstance = true)
Severity: Minor
Found in src/Instances/Container.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getReadinessProbe has a boolean flag argument $asInstance, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getReadinessProbe(bool $asInstance = true)
Severity: Minor
Found in src/Instances/Container.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status