Sign upLogin

renuo/ngx-renuo-upload

View on GitHub
Star

Showing 33 of 33 total issues

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  removeAlert(errorMessage: ErrorMessage) {
    this.alertList = this.alertList.filter(alert => alert !== errorMessage);
  }
Severity: Major
Found in src/app/demo/demo.component.ts and 4 other locations - About 35 mins to fix
src/app/demo/gallery-demo/gallery-demo.component.ts on lines 26..28
src/app/demo/image-demo/image-demo.component.ts on lines 37..39
src/app/demo/multi-upload-demo/multi-upload-demo.component.ts on lines 24..26
src/app/demo/single-upload-demo/single-upload-demo.component.ts on lines 28..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  removeAlert(errorMessage: ErrorMessage) {
    this.alertList = this.alertList.filter(alert => alert !== errorMessage);
  }
Severity: Major
Found in src/app/demo/single-upload-demo/single-upload-demo.component.ts and 4 other locations - About 35 mins to fix
src/app/demo/demo.component.ts on lines 51..53
src/app/demo/gallery-demo/gallery-demo.component.ts on lines 26..28
src/app/demo/image-demo/image-demo.component.ts on lines 37..39
src/app/demo/multi-upload-demo/multi-upload-demo.component.ts on lines 24..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  removeAlert(errorMessage: ErrorMessage) {
    this.alertList = this.alertList.filter(alert => alert !== errorMessage);
  }
Severity: Major
Found in src/app/demo/image-demo/image-demo.component.ts and 4 other locations - About 35 mins to fix
src/app/demo/demo.component.ts on lines 51..53
src/app/demo/gallery-demo/gallery-demo.component.ts on lines 26..28
src/app/demo/multi-upload-demo/multi-upload-demo.component.ts on lines 24..26
src/app/demo/single-upload-demo/single-upload-demo.component.ts on lines 28..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  removeAlert(errorMessage: ErrorMessage) {
    this.alertList = this.alertList.filter(alert => alert !== errorMessage);
  }
Severity: Major
Found in src/app/demo/gallery-demo/gallery-demo.component.ts and 4 other locations - About 35 mins to fix
src/app/demo/demo.component.ts on lines 51..53
src/app/demo/image-demo/image-demo.component.ts on lines 37..39
src/app/demo/multi-upload-demo/multi-upload-demo.component.ts on lines 24..26
src/app/demo/single-upload-demo/single-upload-demo.component.ts on lines 28..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

  removeAlert(errorMessage: ErrorMessage) {
    this.alertList = this.alertList.filter(alert => alert !== errorMessage);
  }
Severity: Major
Found in src/app/demo/multi-upload-demo/multi-upload-demo.component.ts and 4 other locations - About 35 mins to fix
src/app/demo/demo.component.ts on lines 51..53
src/app/demo/gallery-demo/gallery-demo.component.ts on lines 26..28
src/app/demo/image-demo/image-demo.component.ts on lines 37..39
src/app/demo/single-upload-demo/single-upload-demo.component.ts on lines 28..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

            return Object.keys(y).every(i => p.indexOf(i) !== -1) &&
              p.every(i => objectEquals(x[i], y[i]));
Severity: Major
Found in src/app/app.component.spec.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                if (x === y || x.valueOf() === y.valueOf()) { return true; }
    Severity: Major
    Found in src/app/app.component.spec.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  if (x instanceof Date) { return false; }
      Severity: Major
      Found in src/app/app.component.spec.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          modifyImage(url: string): string {
    return this.imageService.modifyImage(url, this.dimensions, this.getFilters());
  }
        Severity: Minor
        Found in src/app/image/image.component.ts and 1 other location - About 30 mins to fix
        src/app/gallery/gallery.component.ts on lines 22..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                    if (!(x instanceof Object)) { return false; }
        Severity: Major
        Found in src/app/app.component.spec.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      if (!(y instanceof Object)) { return false; }
          Severity: Major
          Found in src/app/app.component.spec.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        if (Array.isArray(x) && x.length !== y.length) { return false; }
            Severity: Major
            Found in src/app/app.component.spec.ts - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                modifyThumbnail(url: string): string {
    return this.imageService.modifyImage(url, this.thumbnailDimensions, this.getFilters());
  }
              Severity: Minor
              Found in src/app/gallery/gallery.component.ts and 1 other location - About 30 mins to fix
              src/app/image/image.component.ts on lines 18..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language