Sign upLogin

renyijiu/id_validator

View on GitHub
Star

Showing 3 of 3 total issues

Method is_valid? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def is_valid?(id_card)
      code = get_id_argument(id_card)

      return false unless check_address_code(code[:address_code])
      return false unless check_birthday_code(code[:birthday_code])
Severity: Minor
Found in lib/id_validator/validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return key.to_s
Severity: Major
Found in lib/id_validator/concern/helper.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return false if check_bit.nil? || (code[:check_bit] != check_bit)
    Severity: Major
    Found in lib/id_validator/validator.rb - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language