Sign upLogin

renz45/mandrill_mailer

View on GitHub
Star

Showing 6 of 6 total issues

Class CoreMailer has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class CoreMailer
    class InvalidEmail < StandardError; end
    class InvalidMailerMethod < StandardError; end
    class InvalidInterceptorParams < StandardError; end
    class InvalidMergeLanguageError < StandardError; end
Severity: Minor
Found in lib/mandrill_mailer/core_mailer.rb - About 2 hrs to fix

    Method format_messages_api_message_data has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.format_messages_api_message_data(args, defaults)
      # If a merge_language attribute is given and it's not one of the accepted
      # languages Raise an error
      if args[:merge_language] && !ACCEPTED_MERGE_LANGUAGES.include?(args[:merge_language])
        raise MandrillMailer::CoreMailer::InvalidMergeLanguageError.new("The :merge_language value `#{args[:merge_language]}`is invalid, value must be one of: #{ACCEPTED_MERGE_LANGUAGES.join(', ')}.")
    Severity: Minor
    Found in lib/mandrill_mailer/arg_formatter.rb - About 1 hr to fix

      Method method_missing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def method_missing(method, *args)
      return super unless defined?(Rails) && Rails.application.routes.url_helpers.respond_to?(method)
      # Check to see if one of the args is an open struct. If it is, we'll assume it's the
      # test stub and try to call a path or url attribute.
      if args.any? {|arg| arg.kind_of?(MandrillMailer::Mock)}
      Severity: Minor
      Found in lib/mandrill_mailer/core_mailer.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method perform has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def perform(template_name, template_content, message, async, ip_pool, send_at, mailer='MandrillMailer::TemplateMailer')
      Severity: Major
      Found in lib/mandrill_mailer/mandrill_template_later.rb - About 50 mins to fix

        Method attachment_args has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.attachment_args(args)
      return unless args
      args.map do |attachment|
        attachment.symbolize_keys!
        type = attachment[:mimetype] || attachment[:type]
        Severity: Minor
        Found in lib/mandrill_mailer/arg_formatter.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def perform(message, async, ip_pool, send_at, mailer='MandrillMailer::MessageMailer')
        Severity: Minor
        Found in lib/mandrill_mailer/mandrill_message_later.rb - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language