rescribet/link-redux

View on GitHub

Showing 111 of 111 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const { result: { current } } = renderHook(() => useStatus(rdfFactory.literal("")), { wrapper });
Severity: Minor
Found in src/hooks/__tests__/useStatus.spec.tsx and 1 other location - About 30 mins to fix
src/hooks/__tests__/useDataInvalidation.spec.tsx on lines 63..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return undefined;
Severity: Major
Found in src/hooks/useLoadingOrError.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return React.createElement(associationRenderer, associationProps, childComp);
    Severity: Major
    Found in src/components/Property.tsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return true;
      Severity: Major
      Found in src/hooks/makeParsedField/useTargetedQuery/queryChanged.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return Number(obj.value);
        Severity: Major
        Found in src/hocs/link/toReturnType.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return null;
          Severity: Major
          Found in src/components/Property.tsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return !equals(previous, next);
            Severity: Major
            Found in src/hooks/makeParsedField/useTargetedQuery/queryChanged.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return obj.value;
              Severity: Major
              Found in src/hocs/link/toReturnType.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return propertyRenderer(
                            renderChildrenOrValue(childProps, lrs),
                            associationRenderer,
                        );
                Severity: Major
                Found in src/components/Property.tsx - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          const { result: { current } } = renderHook(() => useValues(array(schema.comment)), { wrapper });
                  Severity: Minor
                  Found in src/hooks/__tests__/useParsedField.spec.tsx and 2 other locations - About 30 mins to fix
                  src/hooks/__tests__/useParsedField.spec.tsx on lines 389..392
                  src/hooks/__tests__/useParsedField.spec.tsx on lines 399..399

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function useTempRecords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const useTempRecords = <T>(
                    items: T[],
                    fields: FieldSet | ItemFieldBuilder<T>,
                    deps: unknown[],
                    givenIds?: SomeNode[],
                  Severity: Minor
                  Found in src/hooks/useTempRecords.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language