Sign upLogin

resource-watch/adapter-earth-engine

View on GitHub
Star

Showing 13 of 13 total issues

Function query has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def query(dataset_id, dataset):
    """Query GEE Dataset Endpoint"""
    logging.info("Doing GEE Query")

    if request.method == "POST":
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(404)
def page_not_found(e):
    logging.error("Not Found")
    return error(status=404, detail="Not Found")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(405)
def method_not_allowed(e):
    logging.error("Method Not Allowed")
    return error(status=405, detail="Method Not Allowed")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(410)
def gone(e):
    logging.error("Gone")
    return error(status=410, detail="Gone")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function download has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def download(dataset_id, dataset):
    """Download GEE Dataset Endpoint"""
    logging.info("Downloading GEE Dataset")

    if request.method == "POST":
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(403)
def forbidden(e):
    logging.error("Forbidden")
    return error(status=403, detail="Forbidden")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(500)
def internal_server_error(e):
    logging.error("Internal Server Error")
    return error(status=500, detail="Internal Server Error")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function build_query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def build_query(dataset, sql=None, fs=None):
    if sql:
        result_query = f"?sql={sql}"
    else:
        if fs.get("dataset"):
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return jsonify(data=serialize_query(response, meta)), 200
Severity: Major
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return jsonify(serialize_query(response, meta)), 200
    Severity: Major
    Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 30 mins to fix

      Function worker_int has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def worker_int(worker):
    worker.log.info("worker received INT or QUIT signal")

    ## get traceback info
    import threading, sys, traceback
      Severity: Minor
      Found in gunicorn.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_dataset_from_id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_dataset_from_id(func):
    @wraps(func)
    def wrapper(*args, **kwargs):
        logging.debug("Getting dataset from id")
        logging.debug("Getting dataset from id")
      Severity: Minor
      Found in adapterearthengine/middleware.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def convert(query, query_type="sql"):
    if not query:
        raise SqlFormatError(message="sql or fs not provided")
    if query_type == "fs" and "&" not in query:
        raise SqlFormatError(message="sql or fs not provided")
      Severity: Minor
      Found in adapterearthengine/services/query_service.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language