Sign upLogin

resource-watch/adapter-earth-engine

View on GitHub
Star

Showing 8 of 13 total issues

Function query has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def query(dataset_id, dataset):
    """Query GEE Dataset Endpoint"""
    logging.info("Doing GEE Query")

    if request.method == "POST":
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function download has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def download(dataset_id, dataset):
    """Download GEE Dataset Endpoint"""
    logging.info("Downloading GEE Dataset")

    if request.method == "POST":
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def build_query(dataset, sql=None, fs=None):
    if sql:
        result_query = f"?sql={sql}"
    else:
        if fs.get("dataset"):
Severity: Minor
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return jsonify(data=serialize_query(response, meta)), 200
Severity: Major
Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return jsonify(serialize_query(response, meta)), 200
    Severity: Major
    Found in adapterearthengine/routes/api/v1/earth_engine_router.py - About 30 mins to fix

      Function worker_int has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def worker_int(worker):
    worker.log.info("worker received INT or QUIT signal")

    ## get traceback info
    import threading, sys, traceback
      Severity: Minor
      Found in gunicorn.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_dataset_from_id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_dataset_from_id(func):
    @wraps(func)
    def wrapper(*args, **kwargs):
        logging.debug("Getting dataset from id")
        logging.debug("Getting dataset from id")
      Severity: Minor
      Found in adapterearthengine/middleware.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def convert(query, query_type="sql"):
    if not query:
        raise SqlFormatError(message="sql or fs not provided")
    if query_type == "fs" and "&" not in query:
        raise SqlFormatError(message="sql or fs not provided")
      Severity: Minor
      Found in adapterearthengine/services/query_service.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language