resource-watch/gee-tiles

View on GitHub

Showing 4 of 4 total issues

Function get_tile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def get_tile(layer, z, x, y, map_object=None, layer_obj=None):
    """Get tile Endpoint"""
    logging.info('[ROUTER]: Getting tile for layer {} and map_object {}'.format(layer, map_object))
    logging.info(map_object)
    try:
Severity: Minor
Found in geetiles/routes/api/v1/tile_router.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_tile has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def get_tile(layer, z, x, y, map_object=None, layer_obj=None):
Severity: Minor
Found in geetiles/routes/api/v1/tile_router.py - About 45 mins to fix

    Function upload_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def upload_file(url, layer, map_id, z, x, y):
    Severity: Minor
    Found in geetiles/services/storage_service.py - About 35 mins to fix

      Function worker_int has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def worker_int(worker):
          worker.log.info("worker received INT or QUIT signal")
      
          ## get traceback info
          import threading, sys, traceback
      Severity: Minor
      Found in gunicorn.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language