resource-watch/graph-client

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async querySimilarDatasets(ctx) {
        logger.info('Obtaining similar datasets', ctx.params.dataset);
        const application = ctx.query.application || ctx.query.app || 'rw';
        const dataset = ctx.params.dataset || ctx.query.dataset || false;
        ctx.assert(dataset, 400, 'dataset query param required');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async querySimilarDatasetsIncludingDescendent(ctx) {
        logger.info('Obtaining similar datasets with descendent', ctx.params.dataset);
        const application = ctx.query.application || ctx.query.app || 'rw';
        const dataset = ctx.params.dataset || ctx.query.dataset || false;
        ctx.assert(dataset, 400, 'dataset query param required');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async conceptsAncestors(ctx) {
        let concepts = null;
        const application = ctx.query.application || ctx.query.app || 'rw';
        if (ctx.query.concepts) {
            concepts = ctx.query.concepts.split(',').map((c) => c.trim());

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async conceptsInferred(ctx) {
        let concepts = null;
        const application = ctx.query.application || ctx.query.app || 'rw';
        if (ctx.query.concepts) {
            concepts = ctx.query.concepts.split(',').map((c) => c.trim());

• Read up
  Read up

File graph.router.js has 475 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable no-underscore-dangle */
const logger = require('logger');
const Router = require('koa-router');
const QueryService = require('services/query.service');
const datasetService = require('services/dataset.service');

File query.service.js has 469 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable no-underscore-dangle */
const logger = require('logger');
const Neo4JService = require('services/neo4j.service');

const CREATE_DATASET = `MERGE (dataset:DATASET {id: {id}, views: 0}) RETURN dataset`;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async createWidgetNodeAndRelation(ctx) {
        logger.info('Creating widget node and relation with idWidget ', ctx.params.idWidget, ' and dataset ', ctx.params.idDataset);
        ctx.set('uncache', `graph-widget widget-graph ${ctx.params.idWidget}-graph`);
        ctx.body = await QueryService.createWidgetNodeAndRelation(ctx.params.idDataset, ctx.params.idWidget);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static async createLayerNodeAndRelation(ctx) {
        logger.info('Creating layer node and relation with idLayer ', ctx.params.idLayer, ' and dataset ', ctx.params.idDataset);
        ctx.set('uncache', `graph-layer layer-graph ${ctx.params.idLayer}-graph`);
        ctx.body = await QueryService.createLayerNodeAndRelation(ctx.params.idDataset, ctx.params.idLayer);
    }

• Read up
  Read up

QueryService has 29 functions (exceeds 20 allowed). Consider refactoring.

Open

class QueryService {

    static async run(query, params) {
        logger.info('Doing query ONLY READ ', query);
        const data = await Neo4JService.query(query, params);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        const data = results.records ? results.records.map((el) => {
            datasetIds.push(el._fields[0]);
            return {
                dataset: el._fields[0],
                views: el._fields[1] ? el._fields[1].low : null

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        const simplifiedViewsCount = viewsCount.records ? viewsCount.records.map((el) => {
            datasetIds.push(el._fields[0]);
            return {
                dataset: el._fields[0],
                views: el._fields[1] ? el._fields[1].low : null

• Read up
  Read up

GraphRouter has 27 functions (exceeds 20 allowed). Consider refactoring.

Open

class GraphRouter {

    static async createDataset(ctx) {
        logger.info('Creating dataset node with id ', ctx.params.id);
        ctx.set('uncache', `graph-dataset dataset-graph ${ctx.params.id}-graph`);

Identical blocks of code found in 3 locations. Consider refactoring.

Open

            if (results.records) {
                results.records.map((el) => {
                    if (el._fields[0].length > 0) {
                        datasetIds = datasetIds.concat(el._fields[0]);
                    }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        if (results.records) {
            results.records.map((el) => {
                if (el._fields[0].length > 0) {
                    datasetIds = datasetIds.concat(el._fields[0]);
                }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        if (results.records) {
            results.records.map((el) => {
                if (el._fields[0].length > 0) {
                    datasetIds = datasetIds.concat(el._fields[0]);
                }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    static async deleteMetadata(ctx) {
        logger.info('Deleting metadata node and relation with idWidget ', ctx.params.id);
        ctx.set('uncache', `graph-metadata metadata-graph ${ctx.params.id}-graph`);
        ctx.body = await QueryService.deleteMetadata(ctx.params.id);
    }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    static async createDataset(ctx) {
        logger.info('Creating dataset node with id ', ctx.params.id);
        ctx.set('uncache', `graph-dataset dataset-graph ${ctx.params.id}-graph`);
        ctx.body = await QueryService.createDatasetNode(ctx.params.id);
    }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    static async deleteWidgetNodeAndRelation(ctx) {
        logger.info('Deleting widget node and relation with idWidget ', ctx.params.id);
        ctx.set('uncache', `graph-widget widget-graph ${ctx.params.id}-graph`);
        ctx.body = await QueryService.deleteWidgetNodeAndRelation(ctx.params.id);
    }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    static async deleteDataset(ctx) {
        logger.info('Deleting dataset node with id ', ctx.params.id);
        ctx.set('uncache', `graph-dataset dataset-graph ${ctx.params.id}-graph`);
        ctx.body = await QueryService.deleteDatasetNode(ctx.params.id);
    }

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    static async deleteLayerNodeAndRelation(ctx) {
        logger.info('Deleting layer node and relation with idWidget ', ctx.params.id);
        ctx.set('uncache', `graph-layer layer-graph ${ctx.params.id}-graph`);
        ctx.body = await QueryService.deleteLayerNodeAndRelation(ctx.params.id);
    }

• Read up
  Read up