Sign upLogin

resource-watch/query

View on GitHub
Star

Showing 65 of 65 total issues

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_guiralossbyiso: {
        uri: '/guira-loss/admin/${iso}',
        method: 'GET',
        arguments: [{
            name: 'iso',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 3..19
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 79..95
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 143..159
app/src/services/endpoints.js on lines 181..197
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749
app/src/services/endpoints.js on lines 771..787

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_viirsfiresbyiso: {
        uri: '/viirs-active-fires/admin/${iso}',
        method: 'GET',
        arguments: [{
            name: 'iso',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 79..95
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 143..159
app/src/services/endpoints.js on lines 181..197
app/src/services/endpoints.js on lines 207..223
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749
app/src/services/endpoints.js on lines 771..787

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_viirsfiresbygeostore: {
        uri: '/viirs-active-fires',
        method: 'GET',
        arguments: [{
            name: 'geostore',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 3..19
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 143..159
app/src/services/endpoints.js on lines 181..197
app/src/services/endpoints.js on lines 207..223
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749
app/src/services/endpoints.js on lines 771..787

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_terraialertsbygeostore: {
        uri: '/terrai-alerts',
        method: 'GET',
        arguments: [{
            name: 'geostore',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 3..19
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 79..95
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 143..159
app/src/services/endpoints.js on lines 181..197
app/src/services/endpoints.js on lines 207..223
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_gladalertsbywdpa: {
        uri: '/glad-alerts/wdpa/${id}',
        method: 'GET',
        arguments: [{
            name: 'id',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 3..19
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 79..95
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 181..197
app/src/services/endpoints.js on lines 207..223
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749
app/src/services/endpoints.js on lines 771..787

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

    cf_gladalertsbygeostore: {
        uri: '/glad-alerts',
        method: 'GET',
        arguments: [{
            name: 'geostore',
Severity: Major
Found in app/src/services/endpoints.js and 14 other locations - About 1 hr to fix
app/src/services/endpoints.js on lines 3..19
app/src/services/endpoints.js on lines 41..57
app/src/services/endpoints.js on lines 79..95
app/src/services/endpoints.js on lines 105..121
app/src/services/endpoints.js on lines 143..159
app/src/services/endpoints.js on lines 207..223
app/src/services/endpoints.js on lines 245..261
app/src/services/endpoints.js on lines 283..299
app/src/services/endpoints.js on lines 451..467
app/src/services/endpoints.js on lines 489..505
app/src/services/endpoints.js on lines 527..543
app/src/services/endpoints.js on lines 695..711
app/src/services/endpoints.js on lines 733..749
app/src/services/endpoints.js on lines 771..787

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            } else if (arg.location === 'query') {
                if (!qs[arg.name]) {
                    qs[arg.name] = argFun.value;
                } else {
                    qs[arg.name] += `,${argFun.value}`;
Severity: Major
Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
app/src/services/query.service.js on lines 111..129
app/src/services/query.service.js on lines 123..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            } else if (arg.location === 'body') {
                if (!body[arg.name]) {
                    body[arg.name] = argFun.value;
                } else {
                    body[arg.name] += `,${argFun.value}`;
Severity: Major
Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
app/src/services/query.service.js on lines 111..129
app/src/services/query.service.js on lines 117..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            } else if (arg.location === 'path') {
                if (!path[arg.name]) {
                    path[arg.name] = argFun.value;
                } else {
                    path[arg.name] += `,${argFun.value}`;
Severity: Major
Found in app/src/services/query.service.js and 2 other locations - About 1 hr to fix
app/src/services/query.service.js on lines 117..129
app/src/services/query.service.js on lines 123..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (() => {

    const loadAPI = (app, path, pathApi) => {
        const routesFiles = fs.readdirSync(path);
        let existIndexRouter = false;
Severity: Minor
Found in app/src/loader.js - About 1 hr to fix

    Function query has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        static async query(ctx) {
        logger.info('Doing query');

        const options = await QueryService.getTargetQuery(ctx, ctx.path.split('/')[1]);
        logger.debug('Doing request to adapter', options);
    Severity: Minor
    Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function jiminy has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async jiminy(ctx) {
        logger.info('Doing jiminy');
        try {

            const options = await QueryService.getTargetQuery(ctx, 'query');
    Severity: Minor
    Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

      Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const loadAPI = (app, path, pathApi) => {
        const routesFiles = fs.readdirSync(path);
        let existIndexRouter = false;
        routesFiles.forEach((file) => {
            const newPath = path ? (`${path}/${file}`) : file;
      Severity: Minor
      Found in app/src/loader.js - About 1 hr to fix

        Function query has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static async query(ctx) {
        logger.info('Doing query');

        const options = await QueryService.getTargetQuery(ctx, ctx.path.split('/')[1]);
        logger.debug('Doing request to adapter', options);
        Severity: Minor
        Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (pathApi) {
                app.use(mount(pathApi, require(newPath).middleware()));
            } else {
                app.use(require(newPath).middleware());
            }
          Severity: Major
          Found in app/src/loader.js and 1 other location - About 1 hr to fix
          app/src/loader.js on lines 25..29

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  if (pathApi) {
                            app.use(mount(pathApi, require(newPath).middleware()));
                        } else {
                            app.use(require(newPath).middleware());
                        }
          Severity: Major
          Found in app/src/loader.js and 1 other location - About 1 hr to fix
          app/src/loader.js on lines 42..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function freeze has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static async freeze(options) {
        const nameFile = `${Date.now()}.json`;
        try {
            logger.debug('Obtaining data');
            const data = await requestPromise(options);
          Severity: Minor
          Found in app/src/routes/api/v1/query.router.js - About 1 hr to fix

            Function checkUserHasPermission has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            const checkUserHasPermission = (user, dataset) => {
    if (user && dataset) {
        // check if user is admin of any application of the dataset or manager and owner of the dataset
        if (user.role === 'MANAGER' && user.id === dataset.userId) {
            return true;
            Severity: Minor
            Found in app/src/services/query.service.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = (() => {

    const loadAPI = (app, path, pathApi) => {
        const routesFiles = fs.readdirSync(path);
        let existIndexRouter = false;
            Severity: Minor
            Found in app/src/loader.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    req.on('response', (response) => {
            ctx.response.status = response.statusCode;
            ctx.set(getHeadersFromResponse(response));
        });
            Severity: Minor
            Found in app/src/routes/api/v1/query.router.js and 1 other location - About 50 mins to fix
            app/src/routes/api/v1/query.router.js on lines 70..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language