Sign upLogin

resource-watch/widget

View on GitHub
Star

Showing 77 of 77 total issues

File widget.router.js has 482 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const Router = require('koa-router');
const logger = require('logger');
const WidgetService = require('services/widget.service');
const DatasetService = require('services/dataset.service');
const RelationshipsService = require('services/relationships.service');
Severity: Minor
Found in app/src/routes/api/v1/widget.router.js - About 7 hrs to fix

    Function get has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

        static async get(ctx) {
        const id = ctx.params.widget;
        const { query } = ctx;
        const { dataset } = ctx.params;
        const user = query.loggedUser && query.loggedUser !== 'null' ? JSON.parse(query.loggedUser) : null;
    Severity: Minor
    Found in app/src/routes/api/v1/widget.router.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File widget.service.js has 432 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const logger = require('logger');
const Widget = require('models/widget.model');
const DatasetService = require('services/dataset.service');
const WidgetNotFound = require('errors/widgetNotFound.error');
const WidgetProtected = require('errors/widgetProtected.error');
    Severity: Minor
    Found in app/src/services/widget.service.js - About 6 hrs to fix

      Function getAll has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

          static async getAll(ctx) {
        const { query } = ctx;
        const dataset = ctx.params.dataset || null;
        const user = query.loggedUser && query.loggedUser !== 'null' ? JSON.parse(query.loggedUser) : null;
        const userId = user ? user.id : null;
      Severity: Minor
      Found in app/src/routes/api/v1/widget.router.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (resource.app.indexOf('@') >= 0) {
                resource.app = {
                    $all: resource.app.split('@').map((elem) => elem.trim())
                };
            } else {
      Severity: Major
      Found in app/src/services/widget.service.js and 1 other location - About 4 hrs to fix
      app/src/services/widget.service.js on lines 369..377

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if (query[param].indexOf('@') >= 0) {
                            query[param] = {
                                $all: query[param].split('@').map((elem) => elem.trim())
                            };
                        } else {
      Severity: Major
      Found in app/src/services/widget.service.js and 1 other location - About 4 hrs to fix
      app/src/services/widget.service.js on lines 447..455

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getAll has 83 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static async getAll(ctx) {
        const { query } = ctx;
        const dataset = ctx.params.dataset || null;
        const user = query.loggedUser && query.loggedUser !== 'null' ? JSON.parse(query.loggedUser) : null;
        const userId = user ? user.id : null;
      Severity: Major
      Found in app/src/routes/api/v1/widget.router.js - About 3 hrs to fix

        Function authorizationMiddleware has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        const authorizationMiddleware = async (ctx, next) => {
    logger.debug(`[WidgetRouter] Checking authorization`);
    // Get user from query (delete) or body (post-patch)
    const newWidgetCreation = ctx.request.path.includes('widget') && ctx.request.method === 'POST' && !(ctx.request.path.includes('find-by-ids'));
    const newWidgetUpdate = ctx.request.path.includes('widget') && ctx.request.method === 'PATCH';
        Severity: Minor
        Found in app/src/routes/api/v1/widget.router.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static async get(ctx) {
        const id = ctx.params.widget;
        const { query } = ctx;
        const { dataset } = ctx.params;
        const user = query.loggedUser && query.loggedUser !== 'null' ? JSON.parse(query.loggedUser) : null;
        Severity: Major
        Found in app/src/routes/api/v1/widget.router.js - About 2 hrs to fix

          Function init has 69 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function init() {
    return new Promise((resolve, reject) => {
        async function onDbReady(err) {
            if (err) {
                if (retries >= 0) {
          Severity: Major
          Found in app/src/app.js - About 2 hrs to fix

            Function getRelationships has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                static async getRelationships(widgets, includes, user, apiKey, query = {}) {
        logger.info(`Getting relationships of widgets: ${widgets}`);
        for (let i = 0; i < widgets.length; i++) {
            try {
                if (includes.indexOf('vocabulary') > -1) {
            Severity: Minor
            Found in app/src/services/relationships.service.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFilteredQuery has 64 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                static getFilteredQuery(query, ids = []) {
        const { collection, favourite } = query;
        if (!query.application && query.app) {
            query.application = query.app;
            if (favourite) {
            Severity: Major
            Found in app/src/services/widget.service.js - About 2 hrs to fix

              Function onDbReady has 63 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      async function onDbReady(err) {
            if (err) {
                if (retries >= 0) {
                    retries -= 1;
                    logger.error(`Failed to connect to MongoDB uri ${mongoUri}, retrying...`);
              Severity: Major
              Found in app/src/app.js - About 2 hrs to fix

                Function validateWidgetCreation has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static async validateWidgetCreation(koaObj) {
        logger.info('[WidgetValidator] Validating widget creation');
        koaObj.checkBody('name')
            .notEmpty()
            .notBlank()
                Severity: Major
                Found in app/src/validators/widget.validator.js - About 2 hrs to fix

                  Function getRelationships has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      static async getRelationships(widgets, includes, user, apiKey, query = {}) {
        logger.info(`Getting relationships of widgets: ${widgets}`);
        for (let i = 0; i < widgets.length; i++) {
            try {
                if (includes.indexOf('vocabulary') > -1) {
                  Severity: Major
                  Found in app/src/services/relationships.service.js - About 2 hrs to fix

                    Function validateWidgetUpdate has 59 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        static async validateWidgetUpdate(koaObj) {
        logger.info('[WidgetValidator] Validating widget update');
        koaObj.checkBody('name')
            .optional()
            .check((v) => WidgetValidator.isString(v), 'must be a string');
                    Severity: Major
                    Found in app/src/validators/widget.validator.js - About 2 hrs to fix

                      Function exports has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      module.exports = (grunt) => {

    grunt.file.setBase('..');
    // eslint-disable-next-line import/no-extraneous-dependencies
    require('load-grunt-tasks')(grunt);
                      Severity: Major
                      Found in app/Gruntfile.js - About 2 hrs to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        const serializeObjToQuery = (obj) => Object.keys(obj).reduce((a, k) => {
    a.push(`${k}=${encodeURIComponent(obj[k])}`);
    return a;
}, []).join('&');
                        Severity: Major
                        Found in app/src/routes/api/v1/widget.router.js and 1 other location - About 2 hrs to fix
                        app/src/services/relationships.service.js on lines 5..8

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 79.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        const serializeObjToQuery = (obj) => Object.keys(obj).reduce((a, k) => {
    a.push(`${k}=${encodeURIComponent(obj[k])}`);
    return a;
}, []).join('&');
                        Severity: Major
                        Found in app/src/services/relationships.service.js and 1 other location - About 2 hrs to fix
                        app/src/routes/api/v1/widget.router.js on lines 18..21

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 79.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    ctx.set('uncache', ['widget', id, widget.slug, `${widget.dataset}-widget`, `${ctx.state.dataset.slug}-widget`, `${ctx.state.dataset.id}-widget-all`]);
                        Severity: Major
                        Found in app/src/routes/api/v1/widget.router.js and 1 other location - About 2 hrs to fix
                        app/src/routes/api/v1/widget.router.js on lines 310..310

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 78.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language