Sign upLogin

resque/resque

View on GitHub
Star
lib/resque/job.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Job has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Job
    include Helpers
    extend Helpers
    def redis
      Resque.redis
Severity: Minor
Found in lib/resque/job.rb - About 3 hrs to fix

    Method perform has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def perform
      job = payload_class
      job_args = args || []
      job_was_performed = false
    Severity: Minor
    Found in lib/resque/job.rb - About 1 hr to fix

      Method perform has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def perform
      job = payload_class
      job_args = args || []
      job_was_performed = false
      Severity: Minor
      Found in lib/resque/job.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run_failure_hooks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def run_failure_hooks(exception)
      begin
        job_args = args || []
        if has_payload_class?
          failure_hooks.each { |hook| payload_class.send(hook, exception, *job_args) } unless @failure_hooks_ran
      Severity: Minor
      Found in lib/resque/job.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status