Sign upLogin

retracedhq/monkit

View on GitHub
Star
src/StatusPageReporter.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function report has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public report(): void {
        const metrics = this.registry.getMetrics();

        if (metrics.counters.length !== 0) {
            metrics.counters.forEach((count) => {
Severity: Minor
Found in src/StatusPageReporter.ts - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (metrics.timers.length !== 0) {
            metrics.timers.forEach((timer) => {
                if (timer.min() != null) {
                    this.reportTimer(timer);
                }
    Severity: Major
    Found in src/StatusPageReporter.ts and 1 other location - About 1 hr to fix
    src/StatsdReporter.ts on lines 50..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (metrics.histograms.length !== 0) {
            metrics.histograms.forEach((histogram) => {
                if (histogram.min != null) {
                    this.reportHistogram(histogram);
                }
    Severity: Major
    Found in src/StatusPageReporter.ts and 1 other location - About 1 hr to fix
    src/StatsdReporter.ts on lines 58..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            if (metrics.gauges.length !== 0) {
            metrics.gauges.forEach((gauge) => {
                this.reportGauge(gauge);
            });
        }
    Severity: Major
    Found in src/StatusPageReporter.ts and 5 other locations - About 50 mins to fix
    src/StatsdReporter.ts on lines 38..42
    src/StatsdReporter.ts on lines 44..48
    src/StatsdReporter.ts on lines 66..70
    src/StatusPageReporter.ts on lines 50..54
    src/StatusPageReporter.ts on lines 56..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            if (metrics.meters.length !== 0) {
            metrics.meters.forEach((meter) => {
                this.reportMeter(meter);
            });
        }
    Severity: Major
    Found in src/StatusPageReporter.ts and 5 other locations - About 50 mins to fix
    src/StatsdReporter.ts on lines 38..42
    src/StatsdReporter.ts on lines 44..48
    src/StatsdReporter.ts on lines 66..70
    src/StatusPageReporter.ts on lines 50..54
    src/StatusPageReporter.ts on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            if (metrics.counters.length !== 0) {
            metrics.counters.forEach((count) => {
                this.reportCounter(count);
            });
        }
    Severity: Major
    Found in src/StatusPageReporter.ts and 5 other locations - About 50 mins to fix
    src/StatsdReporter.ts on lines 38..42
    src/StatsdReporter.ts on lines 44..48
    src/StatsdReporter.ts on lines 66..70
    src/StatusPageReporter.ts on lines 56..60
    src/StatusPageReporter.ts on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    trailing whitespace
    Open

     *
    Severity: Minor
    Found in src/StatusPageReporter.ts by tslint

    Rule: no-trailing-whitespace

    Disallows trailing whitespace at the end of a line.

    Rationale

    Keeps version control diffs clean as it prevents accidental whitespace from being committed.

    Notes
    • Has Fix

    Config

    Possible settings are:

    • "ignore-template-strings": Allows trailing whitespace in template strings.
    • "ignore-comments": Allows trailing whitespace in comments.
    • "ignore-jsdoc": Allows trailing whitespace only in JSDoc comments.
    • "ignore-blank-lines": Allows trailing whitespace on empty lines.
    Examples
    "no-trailing-whitespace": true
    "no-trailing-whitespace": true,ignore-comments
    "no-trailing-whitespace": true,ignore-jsdoc
    Schema
    {
  "type": "array",
  "items": {
    "type": "string",
    "enum": [
      "ignore-comments",
      "ignore-jsdoc",
      "ignore-template-strings",
      "ignore-blank-lines"
    ]
  }
}

    For more information see this page.

    There are no issues that match your filters.

    Category
    Status