Sign upLogin

rewinfrey/action_logic

View on GitHub
Star

Showing 2 of 2 total issues

Method validate! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def self.validate!(validation_rules, context)
        return unless validation_rules.values.find { |expected_validation| expected_validation[:type] }

        type_errors = validation_rules.reduce([]) do |collection, (expected_attribute, expected_validation)|
          next collection unless expected_validation[:type]
Severity: Minor
Found in lib/action_logic/action_validation/type_validation.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method error_message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def self.error_message(expected_attribute, expected_validation, context)
        case expected_validation[:presence]
        when TrueClass then "Attribute: #{expected_attribute} is missing value in context but presence validation was specified" unless context[expected_attribute]
        when Proc      then "Attribute: #{expected_attribute} is missing value in context but custom presence validation was specified" unless expected_validation[:presence].call(context[expected_attribute])
        else
Severity: Minor
Found in lib/action_logic/action_validation/presence_validation.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language