traits/ConfirmationTrait.php
Function resetConfirmation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function resetConfirmation(): void
{
$contentAttribute = $this->contentAttribute;
if (empty($contentAttribute)) {
return;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The 'getIsConfirmed()' method which returns a boolean should be named 'is...()' or 'has...()' Open
Open
public function getIsConfirmed(): bool
{
$cAttribute = $this->confirmationAttribute;
return !(is_string($cAttribute) && !empty($cAttribute)) || $this->$cAttribute > self::CONFIRMATION_STATUS_UNCONFIRMED;
}- Read upRead up
- Exclude checks
BooleanGetMethodName
Since: 0.2
Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.
Example
class Foo {
/**
* @return boolean
*/
public function getFoo() {} // bad
/**
* @return bool
*/
public function isFoo(); // ok
/**
* @return boolean
*/
public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}Source https://phpmd.org/rules/naming.html#booleangetmethodname
Line exceeds 120 characters; contains 126 characters Open
Open
return !(is_string($cAttribute) && !empty($cAttribute)) || $this->$cAttribute > self::CONFIRMATION_STATUS_UNCONFIRMED;- Exclude checks