rhosocial/yii2-base-models

View on GitHub
traits/GUIDTrait.php

Summary

Maintainability
A
1 hr
Test Coverage

Function compositeGUIDs has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public static function compositeGUIDs(mixed $models): array|string|null
    {
        if (empty($models)) {
            return null;
        }
Severity: Minor
Found in traits/GUIDTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method compositeGUIDs() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    public static function compositeGUIDs(mixed $models): array|string|null
    {
        if (empty($models)) {
            return null;
        }
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Avoid using static access to class '\rhosocial\base\helpers\Number' in method 'setGUID'.
Open

            $guid = Number::guid(false, false, $guid);
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\rhosocial\base\helpers\Number' in method 'generateGuid'.
Open

        return Number::guid();
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\rhosocial\base\helpers\Number' in method 'composite_guid_strs'.
Open

        $validGuids = Number::unsetInvalidGUIDs($guids);
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\rhosocial\base\helpers\Number' in method 'getReadableGUID'.
Open

        return Number::guid(false, false, $guid);
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\rhosocial\base\helpers\Number' in method 'compositeGUIDs'.
Open

                    $guids[] = Number::guid(false, false, $model);
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Method name "GUIDTrait::divide_guid_strs" is not in camel caps format
Open

    public static function divide_guid_strs($guids): array
Severity: Minor
Found in traits/GUIDTrait.php by phpcodesniffer

Method name "GUIDTrait::composite_guid_strs" is not in camel caps format
Open

    public static function composite_guid_strs($guids): string
Severity: Minor
Found in traits/GUIDTrait.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in traits/GUIDTrait.php by phpcodesniffer

The method composite_guid_strs is not named in camelCase.
Open

    public static function composite_guid_strs($guids): string
    {
        if (!is_array($guids) || empty($guids)) {
            return '';
        }
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method divide_guid_strs is not named in camelCase.
Open

    public static function divide_guid_strs($guids): array
    {
        if (!is_string($guids) || strlen($guids) == 0 || strlen($guids) % 36 > 0) {
            return [];
        }
Severity: Minor
Found in traits/GUIDTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status