Sign upLogin

rhosocial/yii2-base-models

View on GitHub
Star
traits/IdentityTrait.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid unused parameters such as '$type'.
Open

    public static function findIdentityByAccessToken($token, $type = null): ?static
Severity: Minor
Found in traits/IdentityTrait.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getAuthKeyRules(): array
    {
        if (!is_string($this->authKeyAttribute) || empty($this->authKeyAttribute)) {
            return [];
        }
Severity: Minor
Found in traits/IdentityTrait.php and 1 other location - About 40 mins to fix
traits/IdentityTrait.php on lines 174..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getAccessTokenRules(): array
    {
        if (!is_string($this->accessTokenAttribute) || empty($this->accessTokenAttribute)) {
            return [];
        }
Severity: Minor
Found in traits/IdentityTrait.php and 1 other location - About 40 mins to fix
traits/IdentityTrait.php on lines 111..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Scope keyword "static" must be followed by a single space
Open

    public static function findIdentity(mixed $identity): ?static
Severity: Minor
Found in traits/IdentityTrait.php by phpcodesniffer

Scope keyword "static" must be followed by a single space
Open

    public static function findIdentityByAccessToken($token, $type = null): ?static
Severity: Minor
Found in traits/IdentityTrait.php by phpcodesniffer

Scope keyword "static" must be followed by a single space
Open

    public static function findIdentityByGuid(mixed $guid): ?static
Severity: Minor
Found in traits/IdentityTrait.php by phpcodesniffer

Line exceeds 120 characters; contains 121 characters
Open

        return (is_string($accessTokenAttribute) && !empty($accessTokenAttribute)) ? $this->$accessTokenAttribute : null;
Severity: Minor
Found in traits/IdentityTrait.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

        return (is_string($accessTokenAttribute) && !empty($accessTokenAttribute)) ? $this->$accessTokenAttribute = $token : null;
Severity: Minor
Found in traits/IdentityTrait.php by phpcodesniffer

There are no issues that match your filters.

Category
Status