File UserOrganizationTrait.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|

Method revokeOrganization has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function revokeOrganization($organization, $revokeIfHasChildren = true)
    {
        if (!($organization instanceof $this->organizationClass))
        {
            $class = $this->organizationClass;

Method createBaseOrganization has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    protected function createBaseOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '', $type = Organization::TYPE_ORGANIZATION)

Method createOrganization has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function createOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

Method createDepartment has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function createDepartment($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

Method setUpDepartment has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function setUpDepartment($name, $parent, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

Function revokeOrganization has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    public function revokeOrganization($organization, $revokeIfHasChildren = true)
    {
        if (!($organization instanceof $this->organizationClass))
        {
            $class = $this->organizationClass;

• Read up
  Read up

Method setUpOrganization has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function setUpOrganization($name, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

Function setUpBaseOrganization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    protected function setUpBaseOrganization($models)
    {
        $model = null;
        $associatedModels = [];
        if (is_array($models)) {

• Read up
  Read up

The method revokeOrganization() has an NPath complexity of 272. The configured NPath complexity threshold is 200.

Open

    public function revokeOrganization($organization, $revokeIfHasChildren = true)
    {
        if (!($organization instanceof $this->organizationClass))
        {
            $class = $this->organizationClass;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method revokeOrganization() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.

Open

    public function revokeOrganization($organization, $revokeIfHasChildren = true)
    {
        if (!($organization instanceof $this->organizationClass))
        {
            $class = $this->organizationClass;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The method revokeOrganization has a boolean flag argument $revokeIfHasChildren, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function revokeOrganization($organization, $revokeIfHasChildren = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '292', column '23').

Open

            throw new \Exception('Failed to set up.');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid using static access to class '\Yii' in method 'setUpOrganization'.

Open

            Yii::error($ex->getMessage(), __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Yii' in method 'revokeOrganization'.

Open

            Yii::error($ex->getMessage(), __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Avoid using static access to class '\Yii' in method 'setUpDepartment'.

Open

            Yii::error($ex->getMessage(), __METHOD__);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

The parameter $gravatar_type is not named in camelCase.

Open

    public function createOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $gravatar_type is not named in camelCase.

Open

    public function setUpOrganization($name, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        $accessChecker = Yii::$app->authManager;
        if (!$accessChecker->checkAccess($this, (new SetUpOrganization)->name)) {
            throw new InvalidParamException("You do not have permission to set up organization.");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $gravatar_type is not named in camelCase.

Open

    public function setUpDepartment($name, $parent, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        if (!($parent instanceof $this->organizationClass)) {
            throw new InvalidParamException('Invalid Parent Parameter.');
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $gravatar_type is not named in camelCase.

Open

    protected function createBaseOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '', $type = Organization::TYPE_ORGANIZATION)
    {
        $class = $this->organizationClass;
        $profileConfig = [
            'name' => $name,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

The parameter $gravatar_type is not named in camelCase.

Open

    public function createDepartment($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description, Organization::TYPE_DEPARTMENT);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething($user_name) {
    }
}

Line exceeds 120 characters; contains 155 characters

Open

        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description, Organization::TYPE_DEPARTMENT);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 161 characters

Open

        return $this->hasMany(get_class($this->getNoInitMember()), [$this->getNoInitMember()->memberAttribute => $this->guidAttribute])->inverseOf('memberUser');

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 135 characters

Open

                $organization->type == Organization::TYPE_ORGANIZATION ? (new RevokeOrganization)->name : (new RevokeDepartment)->name,

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 124 characters

Open

            $models = $this->createOrganization($name, null, $nickname, $gravatar_type, $gravatar, $timezone, $description);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 124 characters

Open

        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 121 characters

Open

        return $this->getOfMembers()->andWhere(['role' => [(new DepartmentAdmin)->name, (new OrganizationAdmin)->name]]);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 143 characters

Open

        return $this->hasOne($this->organizationLimitClass, [$this->getNoInitOrganizationLimit()->createdByAttribute => $this->guidAttribute]);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 125 characters

Open

            $models = $this->createDepartment($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 147 characters

Open

        return $this->hasMany($this->organizationClass, [$this->guidAttribute => $this->getNoInitMember()->createdByAttribute])->via('ofCreators');

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 149 characters

Open

    public function createDepartment($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 199 characters

Open

    protected function createBaseOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '', $type = Organization::TYPE_ORGANIZATION)

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 134 characters

Open

    public function setUpOrganization($name, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 151 characters

Open

    public function createOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 141 characters

Open

    public function setUpDepartment($name, $parent, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 153 characters

Open

        return $this->hasMany($this->organizationClass, [$this->guidAttribute => $this->getNoInitMember()->createdByAttribute])->via('ofAdministrators');

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 125 characters

Open

        return $this->getOfMembers()->andWhere(['role' => [(new DepartmentCreator)->name, (new OrganizationCreator)->name]]);

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 146 characters

Open

        return $this->hasMany($this->organizationClass, [$this->guidAttribute => $this->getNoInitMember()->createdByAttribute])->via('ofMembers');

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

     * 

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function call not indented correctly; expected 12 spaces but found 16

Open

                $this,

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 9

Open

        foreach ($organizations as $org)

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 0

Open

            if ($result instanceof \Exception){

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function call not indented correctly; expected 8 spaces but found 16

Open

                ['organization' => $organization])) {

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

     * 

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

     * 

• Exclude checks
  • Disable engine
  • Disable check

Whitespace found at end of line

Open

     * 

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after closing parenthesis; found 9

Open

        if (!($organization instanceof $this->organizationClass))

• Exclude checks
  • Disable engine
  • Disable check

Multi-line function call not indented correctly; expected 12 spaces but found 16

Open

                $organization->type == Organization::TYPE_ORGANIZATION ? (new RevokeOrganization)->name : (new RevokeDepartment)->name,

• Exclude checks
  • Disable engine
  • Disable check

Closing parenthesis of a multi-line function call must be on a line by itself

Open

                ['organization' => $organization])) {

• Exclude checks
  • Disable engine
  • Disable check

The variable $gravatar_type is not named in camelCase.

Open

    public function setUpOrganization($name, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        $accessChecker = Yii::$app->authManager;
        if (!$accessChecker->checkAccess($this, (new SetUpOrganization)->name)) {
            throw new InvalidParamException("You do not have permission to set up organization.");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $gravatar_type is not named in camelCase.

Open

    public function createOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $gravatar_type is not named in camelCase.

Open

    public function createDepartment($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        return $this->createBaseOrganization($name, $parent, $nickname, $gravatar_type, $gravatar, $timezone, $description, Organization::TYPE_DEPARTMENT);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $gravatar_type is not named in camelCase.

Open

    public function setUpDepartment($name, $parent, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
    {
        if (!($parent instanceof $this->organizationClass)) {
            throw new InvalidParamException('Invalid Parent Parameter.');
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $gravatar_type is not named in camelCase.

Open

    protected function createBaseOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '', $type = Organization::TYPE_ORGANIZATION)
    {
        $class = $this->organizationClass;
        $profileConfig = [
            'name' => $name,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}