Sign upLogin

rhosocial/yii2-organization

View on GitHub
Star

Showing 816 of 816 total issues

Avoid using undefined variables such as '$behaviors' which will lead to PHP notices.
Open

            $behaviors[] = [
Severity: Minor
Found in OperatorTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$behaviors' which will lead to PHP notices.
Open

            return $behaviors;
Severity: Minor
Found in OperatorTrait.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$errors' which will lead to PHP notices.
Open

        if (!Module::validateIPRanges($organization, Yii::$app->request->userIP, $errors)) {
Severity: Minor
Found in web/organization/controllers/JoinController.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Method actionJoin has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionJoin($entrance)
    {
        $organization = static::getOrganization($entrance);
        $user = Yii::$app->user->identity;
        if ($organization->creator->equals($user)) {
Severity: Minor
Found in web/organization/controllers/JoinController.php - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php if ($tips): ?>
<div class="well well-sm">
    <?= Yii::t('organization', 'Organization List Directions:') ?>
    <ol>
        <li><?= Yii::t('organization', 'If no search criteria are specified, all organizations and departments are displayed.') ?></li>
    Severity: Major
    Found in widgets/views/organization-list.php and 1 other location - About 1 hr to fix
    widgets/views/member-list-tips.php on lines 15..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            [
            'label' => Yii::t('organization', 'Role'),
            'value' => function($model, $widget) use ($member) {
                if (empty($member->role)) {
                    return null;
    Severity: Major
    Found in web/organization/views/my/_member_profile.php and 1 other location - About 1 hr to fix
    web/organization/views/my/zh-CN/_member_profile.php on lines 36..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            [
            'label' => Yii::t('organization', 'Role'),
            'value' => function($model, $widget) use ($member) {
                if (empty($member->role)) {
                    return null;
    Severity: Major
    Found in web/organization/views/my/zh-CN/_member_profile.php and 1 other location - About 1 hr to fix
    web/organization/views/my/_member_profile.php on lines 36..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php if ($tips): ?>
    <div class="well well-sm">
        <?= Yii::t('organization', 'Member List Directions:') ?>
        <ol>
            <li><?= Yii::t('organization', 'If no search criteria are specified, all members are displayed.') ?></li>
    Severity: Major
    Found in widgets/views/member-list-tips.php and 1 other location - About 1 hr to fix
    widgets/views/organization-list.php on lines 189..204

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method revokeRole has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function revokeRole($role)
    {
        $user = $this->memberUser;
        if (!$user) {
            throw new InvalidValueException('Invalid User');
    Severity: Minor
    Found in Member.php - About 1 hr to fix

      Method initVisibleButtons has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function initVisibleButtons()
    {
        if (!empty($this->visibleButtons)) {
            return;
        }
      Severity: Minor
      Found in grid/OrganizationListActionColumn.php - About 1 hr to fix

        Method assignAdministrator has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function assignAdministrator()
    {
        $host = $this->organization;
        /* @var $host Organization */
        if ($this->isCreator()) {
        Severity: Minor
        Found in Member.php - About 1 hr to fix

          Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function run($org)
    {
        $organization = Module::getOrganization($org);
        $user = Yii::$app->user->identity;
        static::checkAccess($organization, $user);
          Severity: Minor
          Found in web/organization/controllers/my/MemberAction.php - About 1 hr to fix

            Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function run($id)
    {
        $organization = Module::getOrganization($id);
        $user = Yii::$app->user->identity;
        static::checkAccess($organization, $user);
            Severity: Minor
            Found in web/organization/controllers/my/SettingsAction.php - About 1 hr to fix

              Method revokeAdministrator has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function revokeAdministrator()
    {
        $host = $this->organization;
        /* @var $host Organization */
        if ($this->isCreator()) {
              Severity: Minor
              Found in Member.php - About 1 hr to fix

                Method initDefaultButtons has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function initDefaultButtons()
    {
        $this->initDefaultButton('view', false);
        $this->initDefaultButton('member', false, [
            'title' => Yii::t('organization', 'Member'),
                Severity: Minor
                Found in grid/OrganizationListActionColumn.php - About 1 hr to fix

                  Method createBaseOrganization has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected function createBaseOrganization($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '', $type = Organization::TYPE_ORGANIZATION)
                  Severity: Major
                  Found in UserOrganizationTrait.php - About 1 hr to fix

                    Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function run($parent)
    {
        $model = new SetUpForm(['user' => Yii::$app->user->identity, 'parent' => $parent]);
        if (!$model->getParent()) {
            throw new BadRequestHttpException(Yii::t('organization', 'Parent Organization/Department Not Exist.'));
                    Severity: Minor
                    Found in web/organization/controllers/my/SetUpDepartmentAction.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            $query = $query->andFilterWhere([
            'LIKE', $this->memberUserAlias . '.id', $this->id,
        ])->andFilterWhere([
            'LIKE', $this->profileAlias . '.nickname', $this->nickname,
        ])->andFilterWhere([
                    Severity: Minor
                    Found in MemberSearch.php and 1 other location - About 55 mins to fix
                    OrganizationSearch.php on lines 205..215

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 98.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            $query = $query->andFilterWhere([
            'LIKE', $this->organizationAlias . '.id', $this->id,
        ])->andFilterWhere([
            'LIKE', $this->profileAlias . '.nickname', $this->nickname,
        ])->andFilterWhere([
                    Severity: Minor
                    Found in OrganizationSearch.php and 1 other location - About 55 mins to fix
                    MemberSearch.php on lines 217..227

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 98.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method createDepartment has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function createDepartment($name, $parent = null, $nickname = '', $gravatar_type = 0, $gravatar = '', $timezone = 'UTC', $description = '')
                    Severity: Major
                    Found in UserOrganizationTrait.php - About 50 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language