web/organization/controllers/MyController.php
Method actions has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function actions()
{
return [
'index' => [
'class' => 'rhosocial\organization\web\organization\controllers\my\IndexAction',Method behaviors has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function behaviors()
{
return [
'access' => [
'class' => AccessControl::class,Avoid using static access to class '\Yii' in method 'behaviors'. Open
Open
throw new UnauthorizedHttpException(Yii::t('organization', 'You do not have access to set up new organization.'));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$id'. Open
Open
public function actionView($id)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid variables with short names like $id. Configured minimum length is 3. Open
Open
public function actionView($id)- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Line exceeds 120 characters; contains 142 characters Open
Open
throw new UnauthorizedHttpException(Yii::t('organization', 'You do not have access to set up new organization.'));- Exclude checks
Line exceeds 120 characters; contains 132 characters Open
Open
[ // Disallow user who does not have `setUpOrganization` permission to access this `set-up-organization` action.- Exclude checks