Sign upLogin

rhosocial/yii2-organization

View on GitHub
Star
web/organization/controllers/my/RemoveMemberAction.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Yii' in method 'initMessages'.
Open

            $this->removeMemberFailedMessage = Yii::t('organization', 'Failed to Remove.');
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\rhosocial\organization\web\organization\Module' in method 'run'.
Open

        $org = Module::getOrganization($org);
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Yii' in method 'checkAccess'.
Open

            throw new RemovePreventedException(Yii::t('organization', 'Administrator can not remove other administrators.'));
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'rhosocial\organization\web\organization\controllers\my\AddMemberAction' in method 'checkAccess'.
Open

        AddMemberAction::checkAccess($org, $user);
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Yii' in method 'initMessages'.
Open

            $this->removeMemberSuccessMessage = Yii::t('organization' ,'Member Removed.');
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid excessively long variable names like $removeMemberFailedMessage. Keep variable name length under 20.
Open

    public $removeMemberFailedMessage;
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $removeMemberSuccessMessage. Keep variable name length under 20.
Open

    public $removeMemberSuccessMessage;
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

        $id = $user;
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public static function checkAccess($org, &$id, $user)
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Space found before comma in function call
Open

            $this->removeMemberSuccessMessage = Yii::t('organization' ,'Member Removed.');
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpcodesniffer

Line exceeds 120 characters; contains 125 characters
Open

            throw new RemovePreventedException(Yii::t('organization', 'Administrator can not remove other administrators.'));
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

            Yii::$app->session->setFlash(Module::SESSION_KEY_MESSAGE, '(' . $id . ') ' . $this->removeMemberSuccessMessage);
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpcodesniffer

No space found after comma in function call
Open

            $this->removeMemberSuccessMessage = Yii::t('organization' ,'Member Removed.');
Severity: Minor
Found in web/organization/controllers/my/RemoveMemberAction.php by phpcodesniffer

There are no issues that match your filters.

Category
Status